Allow components with Unit props to be constructed without any parameters #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadaj
force-pushed
the
propless-component-apply
branch
from
6c527e8 to
b617c85
Compare
Atry
added a commit
to Atry/slinky
that referenced
this pull request
Jul 1, 2023
Upgrade sbt to 1.1.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, to construct a component or external component taking
Unitfor props, you would have to pass in()as props. Now, such components can be constructed without any arguments to the apply method.MyComponent(())->MyComponent()(the original apply method still works)This currently doesn't work in IntelliJ, but there is an issue opened https://youtrack.jetbrains.com/issue/SCL-12375