Bump Scala version to 2.12.6 and fix provider macros #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous provider macros, which grab the typeclass for the Props/State members of component objects at the wrapper constructor level. In Scala 2.12.4, there was a bug that allowed illegal qualifiers (scala/scala#6359), which allowed the macro implmementations to run without failures. But in 2.12.5, this was fixed and so all the provider macros began to fail with errors for not having a stable identifier. This PR fixes the macros by creating an intermediate variable annotated with `@uncheckedStable`, which lets us access the Props/State types even though we use an unstable path. Fixes #142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous provider macros, which grab the typeclass for the Props/State members of component objects at the wrapper constructor level. In Scala 2.12.4, there was a bug that allowed illegal qualifiers (scala/scala#6359), which allowed the macro implmementations to run without failures. But in 2.12.5, this was fixed and so all the provider macros began to fail with errors for not having a stable identifier. This PR fixes the macros by creating an intermediate variable annotated with
@uncheckedStable, which lets us access the Props/State types even though we use an unstable path.Fixes #142