react-native facades #214
react-native facades #214
Conversation
| import scala.scalajs.js.annotation.JSImport | ||
|
|
||
| @react object TouchableHighlight extends ExternalComponent { | ||
| case class Props(onPress: () => Unit, |
There was a problem hiding this comment.
Looks like onPress is optional according to the docs, so this should be js.UndefOr[() => Unit]. Same for TouchableOpacity.
There was a problem hiding this comment.
That is true, but is it useful to have a Touchable component without an onPress action? Don't we lose some typesafety by making it optional?
There was a problem hiding this comment.
My general approach is to match what the docs say, and in this case the onPress is marked as optional, so I would prefer having the type here also be optional so that anything that works in JS also works in Slinky.
For typesafety, I feel that the more important aspect is the shape of the value when it is provided, not as much having the property passed in or not since the developer usually has an idea of which props they want to specify and IDEs still give information on what props are available.
shadaj
force-pushed
the
master
branch
2 times, most recently
from
e0c6fd8 to
61e62a7
Compare
commit 525236746ccf6860643740800de48f3c10a1e6d0 Author: Shadaj Laddad <[email protected]> Date: Wed Apr 17 23:50:47 2019 -0700 Improve facade typings and update changelog commit c8cd32cc60c95bd01a801007dedbf87e0e2eb1ca Merge: 9642da1 6db5e37 Author: Shadaj Laddad <[email protected]> Date: Wed Apr 17 23:48:16 2019 -0700 Merge branch 'facades' of git://github.com/dohrayme/slinky into dohrayme-facades commit 6db5e37 Author: Ray Price <[email protected]> Date: Wed Jan 2 16:29:11 2019 +0000 react-native facades
|
Manually merged as 7cbb79b |
some additional react-native facades I've found useful