Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate target casting and improve synthetic event typesafety #243

Merged
merged 20 commits into from
Mar 17, 2019
Merged

Eliminate target casting and improve synthetic event typesafety #243

merged 20 commits into from
Mar 17, 2019

Conversation

shadaj
Copy link
Owner

@shadaj shadaj commented Mar 9, 2019 •
edited
Loading

🎉

Fixes #24

@shadaj shadaj added this to the v0.6.0 milestone Mar 9, 2019
shadaj added 19 commits March 9, 2019 14:10
@shadaj
Don't use varargs to create tag elements
c682972
@shadaj
Make TagMod native to skip performance hit when converting Seq[ReactE…
667588e 
…lement]
@shadaj
Simplify the attr vs children separation everywhere else
d0435da
@shadaj
Fix native module compilation
c52f3d7
@shadaj
More bundle size optimizations
b77dd8a
@shadaj
Tuned inlining based on Brotli results
cc03efb
@shadaj
Only allow single curried tag apply
cef53b0
@shadaj
Remove unnecessary implicit
b96fff5
@shadaj
Make AttrPair values public again
ba85f18
@shadaj
Don't make CustomAttribute an AnyVal because it causes crash (Scala.j…
018ad47 
…s bug?)
@shadaj
Add synthetic mouse and clipboard events
ce1adfa
@shadaj
Rearrange event handler definitions and start building synthetic even…
a9c2a5b 
…t types
@shadaj
Fix TagTest compilation failure
28337aa
@shadaj
Implement remaining synthetic event types
b6faf7e
@shadaj
Add type definitions for all HTML tags
a5acdb6
@shadaj
Update docs
1ce0ce9
@shadaj
Make synthetic events variant in the target and event type
1bb2e6d
@shadaj
Update changelog to detail breaking changes
78befac
@shadaj
Bump React Router version
42a5576
@shadaj shadaj changed the title [WIP] Make event handlers type safe and eliminate target casting Make event handlers typesafe and eliminate target casting Mar 17, 2019
@shadaj shadaj changed the title Make event handlers typesafe and eliminate target casting Eliminate event handler target casting and improve typesafety Mar 17, 2019
@shadaj shadaj changed the title Eliminate event handler target casting and improve typesafety Eliminate event target casting and improve typesafety Mar 17, 2019
@shadaj shadaj changed the title Eliminate event target casting and improve typesafety Eliminate event target casting and improve event property typesafety Mar 17, 2019
@shadaj shadaj changed the title Eliminate event target casting and improve event property typesafety Eliminate event target casting and improve synthetic event typesafety Mar 17, 2019
@shadaj shadaj changed the title Eliminate event target casting and improve synthetic event typesafety Eliminate target casting and improve synthetic event typesafety Mar 17, 2019
@shadaj shadaj merged commit 6f594e4 into master Mar 17, 2019
This was referenced Mar 18, 2019
Closed
Closed
@shadaj shadaj mentioned this pull request Mar 18, 2019
Closed
@shadaj shadaj deleted the attrs-without-event-casting branch March 25, 2019 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
1 participant
@shadaj