Move router and history out of docs into main #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add macro settings to web project, for this to work
## To make a commit, type your commit message and press CTRL-ENTER.
## To cancel the commit, close the window. To sign off on the commit,
## press CTRL-S.
##
## You may also reference or close a GitHub issue with this commit.
## To do so, type `#` followed by the `tab` key. You will be shown a
## list of issues related to the current repo. You may also type
## `owner/repo#` plus the `tab` key to reference an issue in a
## different GitHub repo.
build.sbt | 3 ++-
{docs => web}/src/main/scala/slinky/history/History.scala | 0
{docs => web}/src/main/scala/slinky/reactrouter/ReactRouterDOM.scala | 0
3 files changed, 2 insertions(+), 1 deletion(-)
|
Thanks for the PR @zakpatterson! The |
|
Ok, think that's good. Let me know what you think. Hopefully this helps people a little; I was just copying the router/history code from the docs into my project. |
zakpatterson
force-pushed
the
feature-add-reactrouter
branch
from
77652b2 to
a4084d7
Compare
shadaj
requested changes
Jan 8, 2020
shadaj
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the react-router and html5 history api to the web project
Also add macro settings to web project, for this to work