Fix build and testing in Windows #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadaj
requested changes
Jan 8, 2020
There was a problem hiding this comment.
This is super awesome @nartamonov! Just one nit but otherwise looks good to go!
native/build.sbt
Outdated
| ) | ||
| } | ||
|
|
||
| def escapeBackslashes(path: String): String = |
There was a problem hiding this comment.
Done. I also rebased changes onto master to resolve conflicts.
…esting on Windows
* Fixed CI badge since Slinky uses Github Actions currently; * Documented issues while importing SBT project in IntelliJ IDEA.
nartamonov
force-pushed
the
fix-windows-build
branch
from
3c111b7 to
fe91718
Compare
shadaj
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed build in Windows OS. I think it will be helpful since not all contributors use Linux for development. I also added standalone job to CI workflow for testing in Windows, but left publication stage not dependent on it. Currently Windows tests works as simple "health" indicator but do not block anything in CI pipeline.