Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ARIA role attribute #309

Merged
merged 2 commits into from
Jan 15, 2020
Merged

Add ARIA role attribute #309

merged 2 commits into from
Jan 15, 2020

Conversation

nartamonov
Copy link
Contributor

According to HTML 5.2:

Every HTML element may have an ARIA role attribute specified. This is an ARIA Role attribute as defined by [wai-aria-1.1].

The attribute, if specified, must have a value that is a set of space-separated tokens; each token must be a non-abstract role defined in the WAI-ARIA specification [wai-aria-1.1].

@nartamonov nartamonov force-pushed the add-role-attribute branch 2 times, most recently from 5dcd8f0 to ae5a892 Compare January 9, 2020 09:37
@nartamonov nartamonov marked this pull request as ready for review January 9, 2020 09:38
shadaj
shadaj approved these changes Jan 15, 2020
View reviewed changes
Copy link
Owner

@shadaj shadaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR @nartamonov!

@shadaj shadaj merged commit dabf670 into shadaj:master Jan 15, 2020
@shadaj shadaj added this to the v0.6.4 milestone Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadaj shadaj shadaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.6.4
Development

Successfully merging this pull request may close these issues.
2 participants
@nartamonov @shadaj