Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron doc #339

Merged
merged 2 commits into from
Apr 7, 2020
Merged

Electron doc #339

merged 2 commits into from
Apr 7, 2020

Conversation

mcallisto
Copy link
Contributor

The new doc refers to a -yet to be created- branch of the official template.

The plan would be:

  1. you create an electron branch in https://github.com/shadaj/create-react-scala-app.g8
  2. I PR into it what is currently into https://github.com/mcallisto/create-react-scala-app.g8/tree/electron
  3. Once merged there, then this PR can also be merged

@shadaj
Copy link
Owner

shadaj commented Apr 6, 2020

@mcallisto created the branch!

README.md Outdated
@@ -23,7 +23,7 @@ Slinky is a framework for writing React apps in Scala with an experience just li
Slinky lets you:
+ Write React components in Scala with an API that mirrors vanilla React
+ Implement interfaces to other React libraries with automatic conversions between Scala and JS types
+ Write apps for React Native and React 360, including the ability to share code with web apps
+ Write apps for React Native, React 360 and Electron, including the ability to share code with web apps
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: extra space and Oxford comma (the second mostly just for consistency)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Owner

@shadaj shadaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shadaj shadaj merged commit e9e3c53 into shadaj:master Apr 7, 2020
@shadaj shadaj added this to the v0.6.5 milestone Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants