Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update scalajs-dom to 1.0.0 #362

Merged
merged 1 commit into from
May 17, 2020
Merged

Update scalajs-dom to 1.0.0 #362

merged 1 commit into from
May 17, 2020

Conversation

povder
Copy link
Contributor

@povder povder commented May 8, 2020

No description provided.

@povder
Copy link
Contributor Author

povder commented May 8, 2020

I'm not sure if we should wait for com.github.japgolly.scalajs-react:core 1.7.0 to be released. 1.6.0 uses scalajs-dom 0.9.8 causing a conflict.

@povder povder marked this pull request as ready for review May 8, 2020 03:50
shadaj
shadaj requested changes May 17, 2020
View reviewed changes
Copy link
Owner

@shadaj shadaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for the PR! Could you add a line to the changelog for this? It's technically a breaking change, but I doubt that many people use dd or dt so probably safe to just release it in the next minor version.

@povder
Copy link
Contributor Author

povder commented May 17, 2020

Thanks for the review, @shadaj . I've added a note in the changelog.

shadaj
shadaj approved these changes May 17, 2020
View reviewed changes
Copy link
Owner

@shadaj shadaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks great!

@shadaj shadaj merged commit 2dffe07 into shadaj:master May 17, 2020
@shadaj shadaj added this to the v0.6.6 milestone May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadaj shadaj shadaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.6.6
Development

Successfully merging this pull request may close these issues.
2 participants
@povder @shadaj