You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Most of our rust-C ffi code uses pub extern "C" fn, but these functions are not allowed by rust to panic (a panic is not allowed to cross the ffi boundary). While Shadow does do this and this is technically UB, it has seemed to work fine for us. But this may break in the future, so we should switch to pub extern "C-unwind" fn instead.
I'm going to close this since in #3210 it's good enough for now. The long-term goal is to get rid of the C code, and if a new rust version in the future causes issues we can revisit. Shadow already seems to SIGABORT when panicking so our unwinding might not be working correctly anyways.
Most of our rust-C ffi code uses
pub extern "C" fn
, but these functions are not allowed by rust to panic (a panic is not allowed to cross the ffi boundary). While Shadow does do this and this is technically UB, it has seemed to work fine for us. But this may break in the future, so we should switch topub extern "C-unwind" fn
instead.See:
c_unwind
rust-lang/rust#106075The text was updated successfully, but these errors were encountered: