-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial stabilisation of c_unwind
#106075
Conversation
r? @nagisa (rustbot has picked a reviewer for you, use r? to override) |
These commits modify compiler targets. Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
This is still waiting for the FCP to begin on the linked tracking issue. Relabeling as such. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes in the compiler seem correct to me.
This is now waiting on @nikomatsakis to resolve their concern regarding the c-unwind docs. @nikomatsakis may choose to resolve their concern, in which case this will go into FCP, or they may choose to raise questions about those docs with the rest of T-lang team (as suggested by Eric Huss on Zulip) @rustbot label: -I-lang-nominated |
FCP is now completed @rustbot label: -S-waiting-on-team |
r=me, see comment, up to you if you think it is worth addressing. |
☔ The latest upstream changes (presumably #109770) made this pull request unmergeable. Please resolve the merge conflicts. |
@nagisa this is pending approval (I don't have review permission) |
@bors r+ rollup=never |
📌 Commit 0ed8428137c52e3fbc9ae470dc5bd00985ee0957 has been approved by It is now in the queue for this repository. |
☔ The latest upstream changes (presumably #110643) made this pull request unmergeable. Please resolve the merge conflicts. |
Rebased |
@bors r=joshtriplett |
☀️ Test successful - checks-actions |
Finished benchmarking commit (1cb6357): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 655.389s -> 655.55s (0.02%) |
Thanks @tmandry and @joshtriplett ! |
The stabilisation report is at #74990 (comment)
cc @rust-lang/wg-ffi-unwind