-
-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Proxy-Only Mode and Transproxy Mode #1446
Conversation
This reverts commit 7fb19c4.
* NAT mode is replaced by transproxy mode; * BaseService classes are moved into bg package and refactored in order to minimize duplicate code; * Local port is moved out of per-profile settings, along with hardcoded DNS port and transproxy (redsocks) port; * Reset is removed since the only possible clean-up needed can be performed by using force stop in app info; * Comparing version code before extracting assets is replaced with a more robust approach: comparing update time. NB: the only code that involves su now is for toggling TFO.
IMO, connection test is not necessary. I'll test these changes first. |
It's good to merge now. |
mobile/src/main/AndroidManifest.xml
Outdated
@@ -12,7 +12,7 @@ | |||
android:required="false"/> | |||
<uses-feature android:name="android.software.leanback" | |||
android:required="false"/> | |||
<uses-feature android:name="android.hardware.camera" | |||
<uses-feature android:name="android.hardware.camera" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why space here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@madeye can handle it if he decides to merge
As suggested by @wongsyrone.
Implement Proxy-Only Mode and Transproxy Mode
Implement Proxy-Only Mode and Transproxy Mode
Type of changes
Details
With which we finally deprecate NAT mode. Fixes #805. Fixes #1441.
BaseService
classes are moved intobg
package and refactored in order to minimize duplicate code;NB: the only code that involves su now is for toggling TFO.
Possible usecases
Proxy-only mode: Use as an upstream proxy for other proxies.
VPN mode: Mostly unchanged.
Transproxy mode: Meant to be used with AFWall+.
Because I'm lazy, I will call them POM, VPN, TPM from now on.
Here's a way to test POM (and possibly useful too since one could also use it under other modes):
adb
;TODO
Do not merge yet. Need more testing and fixing these TODOs.
firewall-shadowsocks-all.sh
orscripts/fireweall-shadowsocks-all.sh
etc.). It seems like we could also provide IPv6 support for TPM usingip6table
.@madeye Would you like to work on these? 😄