Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle swapchain recreation #1830

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

ngoquang2708
Copy link
Contributor

@ngoquang2708 ngoquang2708 commented Dec 20, 2024

Fix black screen in XWayland.

I have very limited knowledge about Vulkan. Let me know if I did anything wrong.

Fix: #1781, #1817.

@ngoquang2708 ngoquang2708 marked this pull request as ready for review December 20, 2024 04:50
@JetPackAndButlers
Copy link

Everything seems to launch fine
image
image
image
image

@Fuoxden
Copy link

Fuoxden commented Dec 23, 2024

Vulkan seems to be fixed for me! Thank you for this bug fix! Hope This gets merged!
Screenshot From 2024-12-23 00-10-52
Screenshot From 2024-12-23 00-10-01
Screenshot From 2024-12-23 00-13-10

@raphaelthegreat raphaelthegreat merged commit 400da1a into shadps4-emu:main Dec 23, 2024
10 checks passed
@ngoquang2708 ngoquang2708 deleted the fix-xwayland branch December 23, 2024 14:28
@C0rn3j
Copy link
Contributor

C0rn3j commented Dec 23, 2024

Looks like it indeed fixed #1781 for me, thank you very much for this!

@rharish101
Copy link

Unfortunately, this didn't fix the issue for me. I'm running Hyprland on Arch Linux, with an AMD RX 7900 XTX (RADV driver), and ran the latest git version of shadps4 from the AUR (https://aur.archlinux.org/packages/shadps4-git). The workaround of unsetting the DISPLAY var works though.

@ngoquang2708
Copy link
Contributor Author

@rharish101 Could you try this #1860.

@rharish101
Copy link

@rharish101 Could you try this #1860.

Thanks a lot, that fixes the issue for me!

@ngoquang2708
Copy link
Contributor Author

@rharish101 If so please report to that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Wayland] All games launch to a black screen with DISPLAY env var set
6 participants