Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HLS): Avoid duplicate AES requests #6399

Merged
merged 3 commits into from
Apr 5, 2024
Merged

fix(HLS): Avoid duplicate AES requests #6399

merged 3 commits into from
Apr 5, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Apr 3, 2024 •
edited
Loading

Fixes #6407

@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround labels Apr 3, 2024
@avelad avelad added this to the v5.0 milestone Apr 3, 2024
@shaka-bot
Copy link
Collaborator

shaka-bot commented Apr 3, 2024 •
edited
Loading

Incremental code coverage: 100.00%

theodab
theodab requested changes Apr 4, 2024
View reviewed changes
lib/hls/hls_parser.js Outdated Show resolved Hide resolved
lib/hls/hls_parser.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab April 4, 2024 09:34
@avelad avelad merged commit ea740ba into shaka-project:main Apr 5, 2024
16 of 17 checks passed
@shaka-bot shaka-bot mentioned this pull request Apr 5, 2024
Merged
@avelad avelad deleted the aes-cache-keys branch April 5, 2024 06:54
@stuartflanagan stuartflanagan mentioned this pull request Apr 16, 2024
Closed
@avelad avelad mentioned this pull request Apr 29, 2024
Open
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 4, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

HLS AES encrypted stream over requesting Key server
3 participants
@avelad @shaka-bot @theodab