Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installation from pip3 is not working on MacBookPro with M2 Pro #194

Closed
avelad opened this issue Nov 8, 2024 · 2 comments · Fixed by #196 or #201
Closed

Installation from pip3 is not working on MacBookPro with M2 Pro #194

avelad opened this issue Nov 8, 2024 · 2 comments · Fixed by #196 or #201
Assignees
@joeyparrish
Labels
platform: macOS Issues affecting macOS type: bug Something isn't working correctly
Milestone
v1.1

Comments

@avelad
Copy link
Member

avelad commented Nov 8, 2024 

alvaroghmpnb@macbookproateme ~ % python3 --version
Python 3.9.6
alvaroghmpnb@macbookproateme ~ % pip3 install --user --upgrade shaka-streamer shaka-streamer-binaries
Collecting shaka-streamer
  Using cached shaka_streamer-1.0.1-py3-none-any.whl.metadata (1.5 kB)
ERROR: Could not find a version that satisfies the requirement shaka-streamer-binaries (from versions: none)
ERROR: No matching distribution found for shaka-streamer-binaries
@avelad avelad added type: bug Something isn't working correctly platform: macOS Issues affecting macOS labels Nov 8, 2024
@avelad avelad changed the title Installation for pip3 is not working on MacBookPro with M2 Pro Installation from pip3 is not working on MacBookPro with M2 Pro Nov 8, 2024
@github-actions github-actions bot added this to the v1.0 milestone Nov 8, 2024
@joeyparrish
Copy link
Member

Heard from @avelad via chat that this is on an M2 pro. I have an M1 in the lab. I'll test there, and hope I can repro and fix with that.

@joeyparrish joeyparrish modified the milestones: v1.0, v1.1 Nov 8, 2024
joeyparrish added a commit to joeyparrish/shaka-streamer that referenced this issue Nov 8, 2024
@joeyparrish
fix(binaries): Fix arm64 mac binary tags
8c1fc03 
I used docs on the [Python wheel format][] to determine that the bit with the OS and CPU is called the "platform tag".  Then I found a [discussion of macOS platform tags][] that gave me the hint that arm64 wheels need to specify macOS 11 at a minimum.

[Python wheel format]: https://peps.python.org/pep-0427/
[discussion of macOS platform tags]: pypa/wheel#387

Closes shaka-project#194
@joeyparrish joeyparrish mentioned this issue Nov 8, 2024
Merged
@joeyparrish
Copy link
Member

I was able to repro on an M1, and validate the fix.

This was referenced Nov 8, 2024
Closed
Merged
joeyparrish added a commit that referenced this issue Nov 10, 2024
@joeyparrish
ci: Test binary installation (#200)
d7b914d 
Closes #197
Could have prevented #194

For a test run with macOS arm64 enabled, showing how this would have
caught #194, see
https://github.com/joeyparrish/shaka-streamer/actions/runs/11762714145/job/32765885894

Once shaka-project/static-ffmpeg-binaries#51
is closed, and we have new builds in the binary package, we can
re-enable macOS arm64 testing for #179.
@shaka-bot shaka-bot mentioned this issue Nov 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeyparrish joeyparrish

Labels
platform: macOS Issues affecting macOS type: bug Something isn't working correctly
Projects
None yet
Milestone
v1.1
2 participants
@joeyparrish @avelad