-
-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue loading popover #174
Issue loading popover #174
Conversation
Webpack:
|
Unless I'm mistaken, this attempts to load bootstrap src, which is written in ES6 and would require a transpiler to be configured. I would drop bootstrap-loader before installing Babel. |
Is that just because of all the additional complexity, @sky-coding? |
I need some more explanation on this change. Why would one want to use the src rather than the dist? debugging? What exactly is the problem being solved? |
@justin808 the reasoning is that their @Judahmeek compiling third-party source code during build is just generally a bad idea, especially when it is in a different language from my source code and would require its own compiler. |
@sky-coding @Andrey-Pavlov @Judahmeek we need some agreement on the preferred solution. I'll release once the 3 of you agree, or if we get more consensus from other community participants. |
@justin808, I followed @sky-coding's advice and addressed #172 through #175. I believe that @sky-coding will agree with me that this PR is unnecessary. @Andrey-Pavlov, would you like to make an argument for this PR or do you agree that we can close this? |
@Judahmeek Let's get a PR for the doc change in that case! Thanks for following up! |
I agree, we can close it. Thank you, everyone! 👍 |
@justin808 #175 is the doc change PR and you've already merged it. |
#172
This change is