Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TS types #1582

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Fix TS types #1582

merged 2 commits into from
Nov 15, 2023

Conversation

kotarella1110
Copy link
Contributor

@kotarella1110 kotarella1110 commented Nov 15, 2023

Summary

resolve ReactOnRails.register type errors that occur when strict is true in ts compiler options

fix ServerRenderResult type for react_component_hash

Pull Request checklist

Remove this line after checking all the items here. If the item is not applicable to the PR, both check it out and wrap it by ~.

  • Add/update test to cover these changes
  • Update documentation
  • Update CHANGELOG file
    Add the CHANGELOG entry at the top of the file.

Other Information

Remove this paragraph and mention any other important and relevant information such as benchmarks.


This change is Reviewable

@kotarella1110 kotarella1110 marked this pull request as ready for review November 15, 2023 11:54
@kotarella1110
Copy link
Contributor Author

CI is down, but it does not appear to be due to this PR change.

@Judahmeek Judahmeek merged commit abf403a into shakacode:master Nov 15, 2023
19 checks passed
@Judahmeek
Copy link
Contributor

@kotarella1110 thank you for your contribution.

Judahmeek added a commit that referenced this pull request Nov 17, 2023
Judahmeek added a commit that referenced this pull request Nov 17, 2023
Judahmeek added a commit that referenced this pull request Nov 17, 2023
Judahmeek added a commit that referenced this pull request Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants