Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add table modifications vignette #184

Merged
merged 13 commits into from
Sep 13, 2022
Merged

add table modifications vignette #184

merged 13 commits into from
Sep 13, 2022

Conversation

shannonpileggi
Copy link
Owner

@shannonpileggi shannonpileggi commented Sep 8, 2022

What changes are proposed in this pull request?

Add a vignette to show how to modify table headers, footnotes, and captions.

If there is an GitHub issue associated with this pull request, please provide link.

Closes #96


Checklist for PR reviewer

  • Ensure all package dependencies are installed by running renv::install()
  • PR branch has pulled the most recent updates from main branch. Ensure the pull request branch and your local version match and both have the latest updates from the main branch.
  • If a new function was added, function included in _pkgdown.yml
  • If a bug was fixed, a unit test was added for the bug check
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features. Review coverage with covr::report(). Before you run, set Sys.setenv(NOT_CRAN="true") and begin in a fresh R session without any packages loaded.
  • R CMD Check runs without errors, warnings, and notes
  • usethis::use_spell_check() runs with no spelling errors in documentation
  • Has NEWS.md been updated with the changes from this pull request under the heading "# gtreg (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • Has the version number been incremented using usethis::use_version(which = "dev")
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge".

@shannonpileggi
Copy link
Owner Author

@ddsjoberg this article is ready for review, let me know what you think!

vignettes/articles/table-modifications.Rmd Outdated Show resolved Hide resolved
vignettes/articles/table-modifications.Rmd Show resolved Hide resolved
vignettes/articles/table-modifications.Rmd Outdated Show resolved Hide resolved
@shannonpileggi
Copy link
Owner Author

@ddsjoberg this is ready for review again

Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fantastic! added just a few minor comments. update or don't update as you like! ❤️

R/selectors.R Outdated Show resolved Hide resolved
# Overview


![](gtreg-modify.gif)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Make the caption bold to match the headers?
  • I feel this fits better beneath the gt table you created?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k i moved it but didn't do the bolding.

vignettes/articles/table-modifications.Rmd Show resolved Hide resolved
vignettes/articles/table-modifications.Rmd Outdated Show resolved Hide resolved
@shannonpileggi
Copy link
Owner Author

@ddsjoberg comments addressed

@ddsjoberg ddsjoberg merged commit 29db5e7 into main Sep 13, 2022
@ddsjoberg ddsjoberg deleted the modify-header-vignette branch September 13, 2022 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add modify header vignette
2 participants