-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add table modifications vignette #184
Conversation
@ddsjoberg this article is ready for review, let me know what you think! |
@ddsjoberg this is ready for review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fantastic! added just a few minor comments. update or don't update as you like! ❤️
# Overview | ||
|
||
|
||
![](gtreg-modify.gif) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Make the caption bold to match the headers?
- I feel this fits better beneath the gt table you created?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
k i moved it but didn't do the bolding.
@ddsjoberg comments addressed |
What changes are proposed in this pull request?
Add a vignette to show how to modify table headers, footnotes, and captions.
If there is an GitHub issue associated with this pull request, please provide link.
Closes #96
Checklist for PR reviewer
renv::install()
_pkgdown.yml
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.covr::report()
. Before you run, setSys.setenv(NOT_CRAN="true")
and begin in a fresh R session without any packages loaded.usethis::use_spell_check()
runs with no spelling errors in documentationNEWS.md
been updated with the changes from this pull request under the heading "# gtreg (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).usethis::use_version(which = "dev")