Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: yat deep link handling #89

Merged
merged 15 commits into from
Jul 19, 2023
Merged

feat: yat deep link handling #89

merged 15 commits into from
Jul 19, 2023

Conversation

0xdef1cafe
Copy link
Collaborator

@0xdef1cafe 0xdef1cafe commented Jun 17, 2023

closes shapeshift/web#4604

can be merged and released before or after shapeshift/web#4794

  • if merged before - web won't handle /yat/* and will just redirect to dashboard
  • if merged after, this will work
720.shorter.mov

TODO

  • yat to change url schema to not use query params ----------- 👇
  • determine web route schema including yat eid - use /#/yat/🦊🚀🌈 - do not use query params
  • scaffold web PR that requires beard oil
  • handle webview navigation to web yat route (use route instead of modal w/ query params)
  • android specific perms?
  • test on android simulator
  • testflight iOS w/ ops
  • "testflight" android w/ ops

AFTER MERGING

  • build on iOS
  • build on android
  • submit to stores

@0xdef1cafe
Copy link
Collaborator Author

blocker - facebook/react-native#36739 bump react-native to 0.70.8 to handle xcode 14.3.1 breaking change

@0xdef1cafe 0xdef1cafe force-pushed the yat-deep-link-handling branch from 577534c to 6e19685 Compare July 7, 2023 02:00
src/App.tsx Show resolved Hide resolved
@0xdef1cafe 0xdef1cafe marked this pull request as ready for review July 10, 2023 06:33
src/App.tsx Outdated Show resolved Hide resolved
@0xean
Copy link
Contributor

0xean commented Jul 11, 2023

@0xdef1cafe - can you outline the best way for me to manual test this functionality?

android/app/src/main/java/com/shapeshift/MainActivity.java Outdated Show resolved Hide resolved
src/App.tsx Show resolved Hide resolved
@0xdef1cafe
Copy link
Collaborator Author

@0xean - please see testing video for confidence i've tested this. here's the commands i used

npx uri-scheme open "shapeshift://yat/%F0%9F%A6%8A%F0%9F%9A%80%F0%9F%8C%88" --android
npx uri-scheme open "shapeshift://yat/%F0%9F%A6%8A%F0%9F%9A%80%F0%9F%8C%88" --ios

Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually LGTM and proven working from the iOS and Android screen captures, let's get this in testflight for runtime testing 🧪

@0xdef1cafe 0xdef1cafe merged commit 12362f5 into main Jul 19, 2023
@0xdef1cafe 0xdef1cafe deleted the yat-deep-link-handling branch July 19, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y.at Final pieces
4 participants