Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes rubocop and specs #199

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixes rubocop and specs #199

wants to merge 3 commits into from

Conversation

PixeLInc
Copy link
Member

@PixeLInc PixeLInc commented Dec 29, 2022 •
edited
Loading

Summary

This pr fixes the long broken rubocop, along with the failing specs.
So we are now green bois again.

Fixed

  • examples/modals.rb to use ENV.fetch instead of ENV[...]
  • lib/discordrb/data/interaction.rb to prefer proc rather than a block to please lord rubocop.
  • spec/data/webhook_spec.rb failing due to missing hash_including call..
  • spec/api/channel_spec.rb failing due to double quotes around the unicode emoji

@PixeLInc PixeLInc changed the title Fixes rubocop and a spec Fixes rubocop and specs Dec 29, 2022
@Dakurei
Copy link
Contributor

Dakurei commented Dec 29, 2022

Fixing the webhook problem does not require changing the test, but fixing the bug in the class directly. I already did it in one of my last PR

591d127

Dakurei added a commit to Dakurei/discordrb that referenced this pull request Mar 28, 2023
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
5827084 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Dakurei added a commit to Dakurei/discordrb that referenced this pull request Mar 28, 2023
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
0327e7c 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Dakurei added a commit to Dakurei/discordrb that referenced this pull request Mar 28, 2023
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
6b55f36 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Dakurei added a commit to Dakurei/discordrb that referenced this pull request Mar 28, 2023
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
a4f26cb 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Dakurei added a commit to Dakurei/discordrb that referenced this pull request Mar 28, 2023
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
2cc7847 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Dakurei added a commit to Dakurei/discordrb that referenced this pull request Mar 28, 2023
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
09b0cbd 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Dakurei added a commit to Dakurei/discordrb that referenced this pull request Mar 28, 2023
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
4b0e061 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Dakurei added a commit to Dakurei/discordrb that referenced this pull request Mar 28, 2023
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
5b75b76 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Dakurei added a commit to Dakurei/discordrb that referenced this pull request Mar 28, 2023
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
de9b570 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Dakurei added a commit to Dakurei/discordrb that referenced this pull request Mar 28, 2023
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
b060cec 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Dakurei added a commit to Dakurei/discordrb that referenced this pull request Mar 28, 2023
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
cd1de8d 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Dakurei added a commit to Dakurei/discordrb that referenced this pull request Apr 22, 2023
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
a019335 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Dakurei added a commit to Dakurei/discordrb that referenced this pull request Apr 24, 2023
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
c092301 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
@Dakurei Dakurei mentioned this pull request Apr 24, 2023
Open
Dakurei added a commit to Dakurei/discordrb that referenced this pull request Apr 25, 2023
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
2ad94ac 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Dakurei added a commit to Dakurei/discordrb that referenced this pull request May 23, 2023
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
6e11fbf 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Dakurei added a commit to Dakurei/discordrb that referenced this pull request Jun 6, 2023
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
9e7ce3f 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Dakurei added a commit to Dakurei/discordrb that referenced this pull request Jun 6, 2023
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
0d9e599 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Dakurei added a commit to Dakurei/discordrb that referenced this pull request Jun 6, 2023
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
8c752f8 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Dakurei added a commit to Dakurei/discordrb that referenced this pull request Jun 26, 2023
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
a961807 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Dakurei added a commit to Dakurei/discordrb that referenced this pull request Jun 26, 2023
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
0faf0c8 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Dakurei added a commit to Dakurei/discordrb that referenced this pull request Jun 28, 2023
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
a38a2e6 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Dakurei added a commit to Dakurei/discordrb that referenced this pull request Jun 28, 2023
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
c16b6ad 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Dakurei added a commit to Dakurei/discordrb that referenced this pull request Jul 5, 2023
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
387a477 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Dakurei added a commit to Dakurei/discordrb that referenced this pull request Jul 5, 2023
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
b38707d 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Dakurei added a commit to Dakurei/discordrb that referenced this pull request Sep 13, 2023
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
b68ef69 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Dakurei added a commit to Dakurei/discordrb that referenced this pull request Sep 13, 2023
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
db75c87 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Dakurei added a commit to Dakurei/discordrb that referenced this pull request Jan 8, 2024
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
7c673b7 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Dakurei added a commit to Dakurei/discordrb that referenced this pull request Jan 8, 2024
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
d5f11ce 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Dakurei added a commit to Dakurei/discordrb that referenced this pull request Jun 15, 2024
@Dakurei
Reversal of a previous modification concerning Webhook#update_webhook
75c157f 
  Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PixeLInc @Dakurei