Update Version Requirements to resolve CircleCI failures #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per Ruby maintenance schedule: https://www.ruby-lang.org/en/downloads/branches/ Rubies 2.7 and 3.0 are end of life, and should not be used. Also, Ruby 3.1 is in security-only maintenance, and should be retired March 2025
Normally you would be able to use the safe navigation (&.) to check for missing values and automatically run `.map` if it's set. However, it appears this sometimes gets passed `false` instead of nil, which is breaking specs. The code should probably be refactored, but leaving that as a future item to reduce the scope of this PR.
|
@Daniel-Worrall @swarley Let me know if you'd like an additional maintainer for this project. I can assist with reviewing PRs and implementing features. |
swarley
approved these changes
Jun 23, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, Discordrb has a failing test suite, and uses end-of-life versions of Ruby for testing. This both fixes the CI failures, and bumps the versions to latest.
There are several new RuboCops that need to be reviewed, but I left that as a future item to reduce scope on this PR.
Added
.devcontainersupport for development of the Discordrb gemChanged
Deprecated
Removed
Fixed