Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edition upgrade #383

Merged
merged 3 commits into from
Jan 7, 2019
Merged

Edition upgrade #383

merged 3 commits into from
Jan 7, 2019

Conversation

alexmaco
Copy link
Contributor

@alexmaco alexmaco commented Jan 5, 2019

This is just a minimal set of changes for the 2018 edition (since recently 1.31 is the minimum supported version).

This does not also change the mod.rs files into $module_name.rs files. Please let me know if you think this should also be done in the same PR.

@sharkdp sharkdp merged commit 051ff59 into sharkdp:master Jan 7, 2019
@sharkdp
Copy link
Owner

sharkdp commented Jan 7, 2019

Thank you very much!

This does not also change the mod.rs files into $module_name.rs files. Please let me know if you think this should also be done in the same PR.

That would be great, but we can do this in another PR.

@alexmaco alexmaco deleted the edition_upgrade branch January 12, 2019 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants