-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NoSeek #487
Add NoSeek #487
Conversation
wcampbell0x2a
commented
Oct 2, 2024
- Add NoSeek to implement Seek for types that won't need to seek, but have the trait impl.
794805e
to
b2fc44a
Compare
Benchmark for 479558bClick to view benchmark
|
Benchmark for 2483c29Click to view benchmark
|
* Add NoSeek to implement Seek for types that won't need to seek, but have the trait impl.
b2fc44a
to
5c60c0a
Compare
Benchmark for 5bdf9d0Click to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! For discovery purposes, it may be nice to have some addition to the docs.
(I'm not sure if a compile 'error'/hint helping the user is possible, but that'd be cool)
Sure, will do.
I wish, but I think since 'Seek` isn't a part of this crate, I dont control the diagnostics. |
add more docs
@sharksforarms added! |
Benchmark for 47ac249Click to view benchmark
|