CompatHelper: bump compat for "Dagger" to "0.12" #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
I can fix that Windows failure if you give me a little bit |
As 0.12.1 fails CI on windows
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
=======================================
Coverage 87.01% 87.01%
=======================================
Files 6 6
Lines 362 362
=======================================
Hits 315 315
Misses 47 47 Continue to review full report at Codecov.
|
|
MacOS failures are my fault too... JuliaParallel/Dagger.jl#252 |
|
@DrChainsaw this is good to go I think. |
|
Great! Thanks for looking out for the downstream :) Should I bump the compat bounds before releasing or was it a CI-only failure? |
DrChainsaw
deleted the
compathelper/new_version/2021-08-06-18-46-08-265-2272451078
branch
|
I would bump the compat bounds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
Daggerpackage from0.9, 0.10, 0.11to0.9, 0.10, 0.11, 0.12.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.