Test added. #79
Open
Test added. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: js/SQLiteHelper.js js/createDatabase.js
add estimate table to DB. add addEstimate() and removeEstimate() functions. add a new link to index.html, so that user can go to estimate page. add addestimate.html and taskestimate.js.
| @@ -9,7 +9,7 @@ $ ./runserver <port> | |||
| where port is a positive integer > 1023. To run the server on a different | |||
| environment, use | |||
|
|
|||
| $ node js/dispatcher.js <node> | |||
| $ node js/dispatcher.js <port> | |||
There was a problem hiding this comment.
Could you also add a note saying you must be in the CourseProject/src directory?
|
I think the comment tests should be a little more robust. Testing just one comment isn't very effective. |
| removes the comments corresponding to the given taskid if it exists. | ||
| */ | ||
| module.exports.removeComments = function (commentsTaskid, callback) { | ||
| queryGetRows("DELETE FROM user WHERE taskid = ?", callback, [commentsTaskid]); |
There was a problem hiding this comment.
are you sure this only deletes comments? It looks like this is deleting an entire row of the user table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add removeComments() to SQLitehelper.js
Add test for comments operations.