Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize CRLF as EOL in inline comments when retokenizing and add a test for that. #137

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Recognize CRLF as EOL in inline comments when retokenizing and add a test for that. #137

merged 1 commit into from
Mar 5, 2019

Conversation

vilemj-Viclick
Copy link
Contributor

@vilemj-Viclick vilemj-Viclick commented Mar 5, 2019

Which issue # if any, does this resolve?
#136

Please check one:

  • New tests created for this change
  • Tests updated for this change

This PR:

  • Adds new API
  • Extends existing API, backwards-compatible
  • Introduces a breaking change
  • Fixes a bug

This fixes a bug that is propagated to stylelint. Ultimately this would result in a new version of stylelint.

@vilemj-Viclick
Copy link
Contributor Author

The Circle CI check's not passing, but this isn't my fault. It says the handlebars package is not secure, but I didn't add that package.

@shellscape
Copy link
Owner

@vilemj-Viclick thank you for opening this PR. Please update your fork from master and push. I have fixed the npm audit that is blocking the CI process for your PR.

@vilemj-Viclick
Copy link
Contributor Author

Alright... I'm not exactly a git ninja (yet) and this is my first forked repo I'm contributing to. But I think I have understood and achieved what you told me to.

Is this correct?

@codecov-io
Copy link

Codecov Report

Merging #137 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #137   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files           8        8           
  Lines         236      236           
=======================================
  Hits          228      228           
  Misses          8        8
Impacted Files Coverage Δ
lib/nodes/inline-comment.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 047f3f1...21c9c25. Read the comment docs.

@shellscape
Copy link
Owner

Yes, that looks correct. Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants