Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore support for yeeting context selectors #431

Open
shepmaster opened this issue Dec 27, 2023 · 1 comment
Open

Restore support for yeeting context selectors #431

shepmaster opened this issue Dec 27, 2023 · 1 comment
Labels
enhancement New feature or request feedback requested User feedback desired on a design decision help wanted Extra attention is needed

Comments

@shepmaster
Copy link
Owner

Originally added in #395, we discovered it caused some type inference issues. In order to release 0.8 with new features, I'm reverting that code for now.

@shepmaster shepmaster added enhancement New feature or request help wanted Extra attention is needed feedback requested User feedback desired on a design decision labels Dec 27, 2023
@shepmaster
Copy link
Owner Author

A repro of the issue at hand:

use snafu::prelude::*;

fn make() -> Option<()> {
    None
}

#[derive(Debug, Snafu)]
pub enum ReproError {
    #[snafu(whatever, display("{}", message))]
    Custom {
        message: String,
        #[snafu(source(from(Box<dyn std::error::Error + Send + Sync + 'static>, Some)))]
        source: Option<Box<dyn std::error::Error + Send + Sync + 'static>>,
    },

    NotNative,
}

fn repro() -> Result<(), ReproError> {
    make().whatever_context("bang")?;

    Ok(())
}

shepmaster added a commit that referenced this issue Dec 27, 2023
This reverts commit d826e6a.

We found type inference regressions in the lead up to 0.8. This
feature doesn't pull its weight yet and is easiest to revert for
now. When `yeet` moves along, we can revisit.

See #431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feedback requested User feedback desired on a design decision help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant