-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[snafu-derive] Support heck v0.5 #451
Conversation
✅ Deploy Preview for shepmaster-snafu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Away from computer at the moment, but I think I want this to be |
We already have that, yay. |
No further changes appear to be necessary. Stop using default features for good measure.
Hi there -- as you might be aware, there's a long-standing issue with Cargo (rust-lang/cargo#5529) where specifying a too-wide version of a dependency can cause cargo updates to flap around between the old and the new versions. Would you be okay just saying heck 0.5 and dropping support for 0.4? |
I was not, so thanks for the heads up!
I actually thought about fixing the bug in Cargo instead of working around it in my crate. However, the reproduction case in that issue doesn’t work anymore. Since you presumably saw this recently, do you have a way to reliably reproduce the problem? |
Sure -- we noticed it in one of our (Oxide's) larger repos:
On x86_64 Linux, this series of commands produces this diff: https://gist.github.com/sunshowers/2973e27d91f17d1a92f6a1fe026ee79c. I'm guessing it's the same on other platforms as well though I haven't verified it. As you can see, the snafu-derive -> heck dependency got updated from 0.5 to 0.4. (I've also observed it go the other way.) |
No further changes appear to be necessary.