Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snafu-derive] Support heck v0.5 #451

Merged
merged 1 commit into from
May 24, 2024
Merged

[snafu-derive] Support heck v0.5 #451

merged 1 commit into from
May 24, 2024

Conversation

Enet4
Copy link
Collaborator

@Enet4 Enet4 commented Apr 13, 2024

No further changes appear to be necessary.

Copy link

netlify bot commented Apr 13, 2024

Deploy Preview for shepmaster-snafu ready!

Name Link
🔨 Latest commit 5b5f80d
🔍 Latest deploy log https://app.netlify.com/sites/shepmaster-snafu/deploys/6650ba38dd594f0008f6551e
😎 Deploy Preview https://deploy-preview-451--shepmaster-snafu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shepmaster
Copy link
Owner

Away from computer at the moment, but I think I want this to be default-features=false, have the version range be >= 0.4, < 0.6, and then probably add a test that it continues to work with version 0.4. 0.5 will be tested in CI automatically.

@shepmaster shepmaster changed the title [snafu-derive] Update heck to v0.5 [snafu-derive] Support heck v0.5 May 24, 2024
@shepmaster
Copy link
Owner

and then probably add a test

We already have that, yay.

@shepmaster shepmaster added the maintenance Keeping the wheels turning label May 24, 2024
No further changes appear to be necessary. Stop using default features
for good measure.
@shepmaster shepmaster merged commit 38cf90a into main May 24, 2024
12 checks passed
@shepmaster shepmaster deleted the imp/heck-0.5 branch May 24, 2024 16:50
@sunshowers
Copy link

sunshowers commented Nov 14, 2024

Hi there -- as you might be aware, there's a long-standing issue with Cargo (rust-lang/cargo#5529) where specifying a too-wide version of a dependency can cause cargo updates to flap around between the old and the new versions. Would you be okay just saying heck 0.5 and dropping support for 0.4?

@shepmaster
Copy link
Owner

as you might be aware

I was not, so thanks for the heads up!

a long-standing issue with Cargo

I actually thought about fixing the bug in Cargo instead of working around it in my crate. However, the reproduction case in that issue doesn’t work anymore. Since you presumably saw this recently, do you have a way to reliably reproduce the problem?

@sunshowers
Copy link

sunshowers commented Nov 14, 2024

Sure -- we noticed it in one of our (Oxide's) larger repos:

git clone https://github.com/oxidecomputer/omicron
cd omicron
git checkout 38cb5542
cargo update -p clap --precise 4.5.21

On x86_64 Linux, this series of commands produces this diff: https://gist.github.com/sunshowers/2973e27d91f17d1a92f6a1fe026ee79c. I'm guessing it's the same on other platforms as well though I haven't verified it.

As you can see, the snafu-derive -> heck dependency got updated from 0.5 to 0.4. (I've also observed it go the other way.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Keeping the wheels turning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants