add comments to helperrvv.h #527
Conversation
luhenry
force-pushed
the
dev/shosie/add-rvv-comments
branch
from
78ea02c to
f78a57b
Compare
|
@blapie rebased this one as well given all the previous PRs were merged. |
| @@ -1292,7 +1335,13 @@ static int vcast_i_vi2(vint2 v) { | |||
| // | |||
|
|
|||
| static vquad loadu_vq_p(const int32_t *ptr) { | |||
| return SLEEF_RVV_DP_VREINTERPRET_VQ(SLEEF_RVV_DP_VREINTERPRET_4VU(SLEEF_RVV_SP_LOAD_2VI(ptr, VECTLENSP * 2))); | |||
There was a problem hiding this comment.
This is only removing a trailing space but doesn't change the code.
src/arch/helperrvv.h
Outdated
| @@ -71,6 +71,11 @@ | |||
| #endif | |||
|
|
|||
| #if __riscv_v_intrinsic <= 12000 | |||
| // __riscv_vcreate* intrinsics only showed up fairly recently, but are useful | |||
There was a problem hiding this comment.
Can we give be a little bit more specific than "fairly recently"?
There was a problem hiding this comment.
I've updated the comment but it turns out I'll need to update the logic as well.
It turns out it was only a coincidence that the feature added at the same time as the feature test macro changed in the compiler versions I checked. Clang took a double-step, updating to 0.12 and then progresively adding the draft features without a version bump. GCC is stuck in between, advertising 0.12 but not implementing vcreate (which is correct, I am wrong).
I'll submit a separate patch to test for clang-18 and up, as well as intrinsics version 1.0 and up.
|
@luhenry @sh1boot I will take care of the general documentation on the website and README (as part of #524), but could you please provide a reference file like https://sleef.org/aarch64.xhtml for rvv types and functions. |
sh1boot
force-pushed
the
dev/shosie/add-rvv-comments
branch
from
f78a57b to
ad9a439
Compare
It's going to take me a while to find time for this (several weeks, at least). AIUI I can broadly copy-paste the SVE documentation but I'll also need to go through the list and make sure everything is present and true. |
Depends on #520, and #521, #503, and #522.
The first commit is already in the #521 PR, but repeated here so I don't have to rebase #503 and #522.
The relevant changes are: rivosinc@78ea02c