Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GoDaddyProvider.ListZonesAsync only gets the first 100 DNS zones #581

Closed
johnburns320 opened this issue Apr 17, 2023 · 1 comment · Fixed by #582
Closed

GoDaddyProvider.ListZonesAsync only gets the first 100 DNS zones #581

johnburns320 opened this issue Apr 17, 2023 · 1 comment · Fixed by #582
Assignees
@shibayan
Labels
bug Something isn't working

Comments

@johnburns320
Copy link
Contributor

Describe the bug
The GoDaddyProvider.ListZonesAsync method is only retrieving the first 100 DNS zones.

To Reproduce
Steps to reproduce the behavior:

  1. Have more than 100 DNS zones with GoDaddy.
  2. Configure Acmebot with valid GoDaddy ApiKey and ApiSecret values.
  3. Click on '+ Add'.
  4. Click on 'DNS Zone' dropdown.
  5. 'DNS Zone' dropdown will only contain the first 100 DNS zones.

Environment (please complete the following information):

  • Certificate Type: N/A
  • Certificate Deploy Target: N/A

Additional context
Add any other context about the problem here.
@johnburns320 johnburns320 added the bug Something isn't working label Apr 17, 2023
johnburns320 added a commit to johnburns320/keyvault-acmebot that referenced this issue Apr 17, 2023
@johnburns320
Enhance GoDaddyProvider.ListZonesAsync method to use marker argument …
9d7766e 
…to get paged list of zones shibayan#581
@johnburns320 johnburns320 mentioned this issue Apr 17, 2023
Merged
@johnburns320
Copy link
Contributor Author

johnburns320 commented Apr 17, 2023 •
edited
Loading

Addressed by #582

@shibayan shibayan linked a pull request May 11, 2023 that will close this issue
Enhance GoDaddyProvider.ListZonesAsync method to use marker argument … #582
Merged
shibayan pushed a commit that referenced this issue May 11, 2023
@johnburns320
Enhance GoDaddyProvider.ListZonesAsync method to use marker argument … (
552e761 
#582)

* Enhance GoDaddyProvider.ListZonesAsync method to use marker argument to get paged list of zones #581

* Apply changes from review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shibayan shibayan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@shibayan @johnburns320