Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

escape paths with regex over quotes in flatpaks #558

Merged
merged 4 commits into from
Jul 19, 2021
Merged

escape paths with regex over quotes in flatpaks #558

merged 4 commits into from
Jul 19, 2021

Conversation

Lunarequest
Copy link

For some reason this stops an intermittent issue where the path supplied to the editor binary would be append with a ".

@Lunarequest Lunarequest mentioned this pull request Jul 17, 2021
Closed
7 tasks
shiftkey
shiftkey approved these changes Jul 19, 2021
View reviewed changes
Copy link
Owner

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit puzzled by this one and why quoting isn't working, but given it's only for Flatpak and there are tests I'm good to take it in. Thanks for the fix @AdvaithM!

@shiftkey shiftkey merged commit 8ef9cea into shiftkey:linux Jul 19, 2021
shiftkey pushed a commit that referenced this pull request Jul 19, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
d8d8648
@Lunarequest
Copy link
Author

I'm a bit puzzled by this one and why quoting isn't working, but given it's only for Flatpak and there are tests I'm good to take it in. Thanks for the fix @AdvaithM!

I suspect there is a bug in flatpak-spawn but I'm not to sure on how to debug it

shiftkey pushed a commit that referenced this pull request Jul 19, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
6b576be
shiftkey pushed a commit that referenced this pull request Jul 22, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
715dca6
shiftkey pushed a commit that referenced this pull request Aug 13, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
ce36f96
shiftkey pushed a commit that referenced this pull request Aug 14, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
de49157
shiftkey pushed a commit that referenced this pull request Aug 20, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
e9b0ae4
shiftkey pushed a commit that referenced this pull request Aug 24, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
c03d2bf
shiftkey pushed a commit that referenced this pull request Aug 24, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
ffcd94a
shiftkey pushed a commit that referenced this pull request Aug 24, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
573547b
shiftkey pushed a commit that referenced this pull request Aug 24, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
474837d
shiftkey pushed a commit that referenced this pull request Aug 24, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
afb3846
shiftkey pushed a commit that referenced this pull request Aug 24, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
0c76b33
shiftkey pushed a commit that referenced this pull request Aug 29, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
6aada91
shiftkey pushed a commit that referenced this pull request Sep 1, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
d7898fb
shiftkey pushed a commit that referenced this pull request Sep 5, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
29bf256
shiftkey pushed a commit that referenced this pull request Sep 5, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
3c6fa8d
shiftkey pushed a commit that referenced this pull request Sep 5, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
f37b969
shiftkey pushed a commit that referenced this pull request Sep 30, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
5228038
shiftkey pushed a commit that referenced this pull request Sep 30, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
81d9c38
shiftkey pushed a commit that referenced this pull request Oct 3, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
947f541
shiftkey pushed a commit that referenced this pull request Oct 7, 2021
@Lunarequest @shiftkey
escape paths with regex over quotes in flatpaks (#558)
e4af842
shiftkey added a commit that referenced this pull request Aug 11, 2024
@shiftkey @Lunarequest
introduce abstractions to make Flatpak integration easier (#555 #558)
851b135 
Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Aug 11, 2024
@shiftkey @Lunarequest
introduce abstractions to make Flatpak integration easier (#555 #558)
22bf947 
Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Aug 12, 2024
@shiftkey @Lunarequest
introduce abstractions to make Flatpak integration easier (#555 #558)
4f56735 
Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Aug 12, 2024
@shiftkey @Lunarequest
feat(tooling): flatpak - introduce abstractions to make Flatpak integ…
40f9f60 
…ration easier (#555 #558)

Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Aug 12, 2024
@shiftkey @Lunarequest
feat(tooling): flatpak - introduce abstractions to make Flatpak integ…
d96e3d5 
…ration easier (#555 #558)

Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Aug 14, 2024
@shiftkey @Lunarequest
feat(tooling): flatpak - introduce abstractions to make Flatpak integ…
07ac492 
…ration easier (#555 #558)

Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Aug 15, 2024
@shiftkey @Lunarequest
feat(tooling): flatpak - introduce abstractions to make Flatpak integ…
3110d6b 
…ration easier (#555 #558)

Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Aug 17, 2024
@shiftkey @Lunarequest
feat(tooling): flatpak - introduce abstractions to make Flatpak integ…
698e9fd 
…ration easier (#555 #558)

Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Aug 17, 2024
@shiftkey @Lunarequest
feat(tooling): flatpak - introduce abstractions to make Flatpak integ…
0cd5506 
…ration easier (#555 #558)

Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Sep 2, 2024
@shiftkey @Lunarequest
feat(tooling): flatpak - introduce abstractions to make Flatpak integ…
a8277c6 
…ration easier (#555 #558)

Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Sep 2, 2024
@shiftkey @Lunarequest
feat(tooling): flatpak - introduce abstractions to make Flatpak integ…
6a3150e 
…ration easier (#555 #558)

Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Oct 30, 2024
@shiftkey @Lunarequest
feat(tooling): flatpak - introduce abstractions to make Flatpak integ…
1636949 
…ration easier (#555 #558)

Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Nov 8, 2024
@shiftkey @Lunarequest
feat(tooling): flatpak - introduce abstractions to make Flatpak integ…
b6b77ed 
…ration easier (#555 #558)

Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Nov 8, 2024
@shiftkey @Lunarequest
feat(tooling): flatpak - introduce abstractions to make Flatpak integ…
66b16e9 
…ration easier (#555 #558)

Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Nov 8, 2024
@shiftkey @Lunarequest
feat(tooling): flatpak - introduce abstractions to make Flatpak integ…
02f0213 
…ration easier (#555 #558)

Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Nov 8, 2024
@shiftkey @Lunarequest
feat(tooling): flatpak - introduce abstractions to make Flatpak integ…
7f80a2c 
…ration easier (#555 #558)

Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Nov 8, 2024
@shiftkey @Lunarequest
feat(tooling): flatpak - introduce abstractions to make Flatpak integ…
f16b40b 
…ration easier (#555 #558)

Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Nov 11, 2024
@shiftkey @Lunarequest
feat(tooling): flatpak - introduce abstractions to make Flatpak integ…
e79ad52 
…ration easier (#555 #558)

Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Nov 11, 2024
@shiftkey @Lunarequest
feat(tooling): flatpak - introduce abstractions to make Flatpak integ…
f95891a 
…ration easier (#555 #558)

Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Nov 11, 2024
@shiftkey @Lunarequest
feat(tooling): flatpak - introduce abstractions to make Flatpak integ…
3cd62b4 
…ration easier (#555 #558)

Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Nov 11, 2024
@shiftkey @Lunarequest
feat(tooling): flatpak - introduce abstractions to make Flatpak integ…
82cfd33 
…ration easier (#555 #558)

Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Nov 11, 2024
@shiftkey @Lunarequest
feat(tooling): flatpak - introduce abstractions to make Flatpak integ…
556133d 
…ration easier (#555 #558)

Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Nov 11, 2024
@shiftkey @Lunarequest
feat(tooling): flatpak - introduce abstractions to make Flatpak integ…
6af9fb0 
…ration easier (#555 #558)

Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Nov 11, 2024
@shiftkey @Lunarequest
feat(tooling): flatpak - introduce abstractions to make Flatpak integ…
700ae24 
…ration easier (#555 #558)

Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Nov 11, 2024
@shiftkey @Lunarequest
feat(tooling): flatpak - introduce abstractions to make Flatpak integ…
12b41dd 
…ration easier (#555 #558)

Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Feb 5, 2025
@shiftkey @Lunarequest
feat(tooling): flatpak - introduce abstractions to make Flatpak integ…
d154ade 
…ration easier (#555 #558)

Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Feb 5, 2025
@shiftkey @Lunarequest
feat(tooling): flatpak - introduce abstractions to make Flatpak integ…
898d5b8 
…ration easier (#555 #558)

Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Feb 5, 2025
@shiftkey @Lunarequest
feat(tooling): flatpak - introduce abstractions to make Flatpak integ…
b5fa85a 
…ration easier (#555 #558)

Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Feb 5, 2025
@shiftkey @Lunarequest
feat(tooling): flatpak - introduce abstractions to make Flatpak integ…
cdd8361 
…ration easier (#555 #558)

Co-Authored-By: nullrequest <[email protected]>
shiftkey added a commit that referenced this pull request Feb 5, 2025
@shiftkey @Lunarequest
feat(tooling): flatpak - introduce abstractions to make Flatpak integ…
a7d8b85 
…ration easier (#555 #558)

Co-Authored-By: nullrequest <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftkey shiftkey shiftkey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lunarequest @shiftkey