This repository has been archived by the owner on Mar 14, 2023. It is now read-only.
Adding support of asUser
#260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @oleg-andreyev, could you please fix tests? |
|
The commit history is fucked up. Could you make a linear history in the PR please? |
…d "should log output" because of deprecations, updated "should copy to remote" to make sure it does not conflict with other builds, added force_color=0 to ensure that "color" is not appended, fixing babelNode resolve
oleg-andreyev
commented
Mar 15, 2020
| @@ -1,3 +1,5 @@ | |||
| process.env.FORCE_COLOR=0; | |||
There was a problem hiding this comment.
without these changes tests aren't passing on local machine
oleg-andreyev
commented
Mar 15, 2020
| @@ -3,22 +3,23 @@ import { exec } from 'ssh-pool' | |||
|
|
|||
| const shipitCli = path.resolve(__dirname, '../src/cli.js') | |||
| const shipitFile = path.resolve(__dirname, './sandbox/shipitfile.babel.js') | |||
| const babelNode = require.resolve('@babel/node/bin/babel-node'); | |||
There was a problem hiding this comment.
instead of hardcoded, resolving from current node context
oleg-andreyev
commented
Mar 15, 2020
| @@ -481,8 +481,8 @@ describe('Connection', () => { | |||
| '/src/dir', | |||
| 'user@host:/dest/dir', | |||
| ) | |||
| expect(output.stdout[0].toString()).toBe('@host first line\n') | |||
| expect(output.stderr[0].toString()).toBe('@host-err an error\n') | |||
| expect(output.stdout.toString()).toContain('@host first line\n') | |||
There was a problem hiding this comment.
deprecations are affecting this assert
|
@gregberge fixed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support of
asUserto shipit.asUseris already supported by ssh-pool because it was not exposed.Also wrapped
asUsercommand withbash -cto ensure thatif [ ... ]; then ..; fi;is supported.