Skip to content

Commit

Permalink
Remote Artifacts EP:
Browse files Browse the repository at this point in the history
Keeping `source` in place, and addding `source` with new remote
artifacts. Avoiding dealing with multiple Git repositories on this EP.
  • Loading branch information
otaviof committed Nov 9, 2020
1 parent 5c2dcee commit 2d1c2ae
Showing 1 changed file with 15 additions and 3 deletions.
18 changes: 15 additions & 3 deletions docs/proposals/remote-artifacts.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,10 @@ spec:
path: $(workspace)/licenses/license.tar
```
The `source` section will be renamed to `sources` in order to accommodate more `type`s of inputs.
Each entry will be composed of the following attributes:
We will add `sources` section, side by side with current `source`. The idea is to accommodate both
constructions in `v1alpha1`, and save API breaking changes for upcoming `v1beta1`.

The new `sources` will contain the following attributes:

- `name`: source name (required);
- `type`: input source type, `git` or `http` (required);
Expand All @@ -90,6 +92,15 @@ Each entry will be composed of the following attributes:
The resource `UID`/`GID` will be defined by the same user running the Tekton task, later on, we
can extend the API to support arbitrary configuration.

### Single vs. Multiple Git Repositories

In `v1alpha1` it's expected to inform the Git repository on `.spec.source`, and external artifacts
informed on `.spec.sources`, therefore, we can address adding this new feature and managing multiple
Git repositories support in different tracks.

For upcoming work, supporting multiple Git repositories will involve re-defining `/workspace/source`
location and `$workspace` placeholder.

### Standalone CRD

Alternatively, we may define the artifacts as a standalone CRD, that is a `BuildSource`
Expand All @@ -108,7 +119,8 @@ metadata:
name: license-file
spec:
sources:
- type: http
- name: license.tar
type: http
url: https://licenses.company.com/customer-id/license.tar
http:
path: $(workspace)/licenses/license.tar
Expand Down

0 comments on commit 2d1c2ae

Please sign in to comment.