Build watch secrets #493
Merged
Build watch secrets #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
qu1queee
force-pushed
the
pairing/build_watch_secrets
branch
12 times, most recently
from
e6a0651 to
7326876
Compare
qu1queee
force-pushed
the
pairing/build_watch_secrets
branch
10 times, most recently
from
553f99f to
a4ff883
Compare
qu1queee
force-pushed
the
pairing/build_watch_secrets
branch
9 times, most recently
from
3ebd077 to
85d0d3b
Compare
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
qu1queee
force-pushed
the
pairing/build_watch_secrets
branch
from
85d0d3b to
7d84cee
Compare
SaschaSchwarze0
requested changes
Dec 2, 2020
qu1queee
force-pushed
the
pairing/build_watch_secrets
branch
2 times, most recently
from
7cb34e2 to
304e77b
Compare
SaschaSchwarze0
requested changes
Dec 3, 2020
docs/development/authentication.md
Outdated
|
|
||
| If you are using `kubectl` command create secrets, then you can first create build secret using `kubectl create secret` command and annotate this secret using `kubectl annotate secrets`. Below is an example: | ||
|
|
||
| ```yaml |
qu1queee
force-pushed
the
pairing/build_watch_secrets
branch
from
304e77b to
beadb1b
Compare
Refactor the Watcher for Secrets Enhance the handler.EnqueueRequestsFromMapFunc Enhance the Events Predicates Signed-off-by: Zoe <[email protected]>
We updated the Build predicates and watcher We added test cases to verify that validations on the Build are taking place when a particular annotation is defined on a secret. Modify build controller watches secrets integration tests Signed-off-by: Zoe <[email protected]>
Signed-off-by: Zoe <[email protected]>
qu1queee
force-pushed
the
pairing/build_watch_secrets
branch
from
beadb1b to
9f2614b
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #466
Worked on this together with @xiujuan95 .
This PR introduces a new Watcher on the Build Controller that watches for Secret Resources. Main things to consider:
build.build.dev/referenced.secret: trueannotation.Buildin the current namespace where the secret is.This PR introduces an extended integration-test for this particular behaviour.
This PR enhance the existing authentication docs, to include what users require to define in the secret and a brief explanation on why this is required.