Fix some of the Go Report Card findings #538
Conversation
|
@HeavyWombat could we use this PR to actually make this validations as part of a new Makefile target, see #445 (comment) ? We might need multiple new make targets, e.g. one for using misspell and another one for using staticcheck |
Yes, good point. I was also wondering if we should add it either as Makefile targets or directly in Travis. Usually, I would prefer that as a |
|
@HeavyWombat yes. I think in this way we enforce people to fix this sanity checks in advance, and in theory we will not have the need of doing standalone prs. We can work on this together, let me know. |
openshift-ci-robot
added
needs-rebase
There was a problem hiding this comment.
Looks good @HeavyWombat. May you update the developer's documentation to introduce the new sanity-check target? Maybe in the Testing guide ?
openshift-ci-robot
added
the
needs-rebase
Add Makefile targets for: - go vet - golint - ineffassign - misspell - staticcheck
Fix `golint` issues for missing comments of exported functions and constants.
Use suggested replacements for `misspell` findings.
Remove trailing whitespaces. Add missing whitespaces between words. Delete duplicate whitespaces.
Remove unused variables reported by `staticcheck`.
Simplify return code on build controller watch call by combining the `return` statement with the watch call. Add `if err != nil` check in build controller `add` function for the `Watch` that checks primary resource builds. Add log statement in e2e test code where the err was assigned, but not checked. Add `Expect` in e2e test code where err was assigned, but not used.
Based on feedback in #538, harmonise function signatures to better match.
Introduce section to explain the new Makefile targets.
openshift-ci-robot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
I went on the Go Report Card of
shipwright-io/buildby chance and saw some minor warnings there. So I decided to quickly fix all warnings that were easy to fix.This includes: