Restructure buildrun code into separate resources #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qu1queee
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
release-note
qu1queee
added
the
do-not-merge/work-in-progress
qu1queee
force-pushed
the
qu1queee/organize_br_reconcile
branch
8 times, most recently
from
4483825 to
30b0e19
Compare
This ensures that between controller definition and reconcile logic, we have a clear separation. This also add a missing suite for the resources internal pkg.
Move some functions into new or existing classes under the internal resource package.
qu1queee
force-pushed
the
qu1queee/organize_br_reconcile
branch
2 times, most recently
from
5a5888c to
362d0b1
Compare
qu1queee
removed
the
do-not-merge/work-in-progress
qu1queee
requested review from
SaschaSchwarze0 and
HeavyWombat
and removed request for
xiujuan95
qu1queee
force-pushed
the
qu1queee/organize_br_reconcile
branch
from
38bc0a8 to
015745d
Compare
This add new unit-tests to ensure a decent code coverage for all the different classes under the resource pkg of buildrun. Signed-off-by: Sascha Schwarze <[email protected]>
qu1queee
force-pushed
the
qu1queee/organize_br_reconcile
branch
from
015745d to
b11e91d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
gabemontero
added
the
kind/cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is a rebase on top of #593 . This PR is doing the following:
resourcepkg, I´m adding a bunch of new unit-tests to increase the coverage of those functions.Submitter Checklist
Release Notes