Guess the file mime type (if not provided) when uploading

shitware-ltd · Oct 11, 2021 · a635052 · a635052
1 parent ca4a7c5
commit a635052
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 6 deletions.
diff --git a/src/GoogleCloudStorage/GoogleCloudStorageAdapter.php b/src/GoogleCloudStorage/GoogleCloudStorageAdapter.php
@@ -22,6 +22,8 @@
 use League\Flysystem\UnableToSetVisibility;
 use League\Flysystem\UnableToWriteFile;
 use League\Flysystem\Visibility;
+use League\MimeTypeDetection\FinfoMimeTypeDetector;
+use League\MimeTypeDetection\MimeTypeDetector;
 use Throwable;
 
 class GoogleCloudStorageAdapter implements FilesystemAdapter
@@ -46,12 +48,23 @@ class GoogleCloudStorageAdapter implements FilesystemAdapter
      */
     private $defaultVisibility;
 
-    public function __construct(Bucket $bucket, string $prefix = '', VisibilityHandler $visibilityHandler = null, string $defaultVisibility = Visibility::PRIVATE)
-    {
+    /**
+     * @var MimeTypeDetector
+     */
+    private $mimeTypeDetector;
+
+    public function __construct(
+        Bucket $bucket,
+        string $prefix = '',
+        VisibilityHandler $visibilityHandler = null,
+        string $defaultVisibility = Visibility::PRIVATE,
+        MimeTypeDetector $mimeTypeDetector = null
+    ) {
         $this->bucket = $bucket;
         $this->prefixer = new PathPrefixer($prefix);
         $this->visibilityHandler = $visibilityHandler ?: new PortableVisibilityHandler();
         $this->defaultVisibility = $defaultVisibility;
+        $this->mimeTypeDetector = $mimeTypeDetector ?: new FinfoMimeTypeDetector();
     }
 
     public function fileExists(string $path): bool
@@ -77,10 +90,7 @@ public function writeStream(string $path, $contents, Config $config): void
     private function upload(string $path, $contents, Config $config): void
     {
         $prefixedPath = $this->prefixer->prefixPath($path);
-        $options = [
-            'name' => $prefixedPath,
-            'metadata' => $config->get('metadata', []),
-        ];
+        $options = ['name' => $prefixedPath];
 
         $visibility = $config->get(Config::OPTION_VISIBILITY, $this->defaultVisibility);
         $predefinedAcl = $this->visibilityHandler->visibilityToPredefinedAcl($visibility);
@@ -89,6 +99,13 @@ private function upload(string $path, $contents, Config $config): void
             $options['predefinedAcl'] = $predefinedAcl;
         }
 
+        $metadata = $config->get('metadata', []);
+        $shouldDetermineMimetype = $contents !== '' && ! array_key_exists('contentType', $metadata);
+        if ($shouldDetermineMimetype && $mimeType = $this->mimeTypeDetector->detectMimeType($path, $contents)) {
+            $metadata['contentType'] = $mimeType;
+        }
+        $options['metadata'] = $metadata;
+
         try {
             $this->bucket->upload($contents, $options);
         } catch (Throwable $exception) {

diff --git a/src/GoogleCloudStorage/GoogleCloudStorageAdapterTest.php b/src/GoogleCloudStorage/GoogleCloudStorageAdapterTest.php
@@ -65,6 +65,17 @@ public function writing_with_specific_metadata(): void
         $this->assertEquals('text/plain+special', $mimeType);
     }
 
+    /**
+     * @test
+     */
+    public function guessing_the_mime_type_when_writing(): void
+    {
+        $adapter = $this->adapter();
+        $adapter->write('some/config.txt', '<?xml version="1.0" encoding="UTF-8"?><test/>', new Config());
+        $mimeType = $adapter->mimeType('some/config.txt')->mimeType();
+        $this->assertEquals('text/xml', $mimeType);
+    }
+
     /**
      * @test
      */