Replaces short-id by nano-id #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Yeah, I have checked this library for a replacement a couple of times in the past, but never really found anything good enough. This one looks like a pretty straightforward replacement if it works as it should. |
acelaya
approved these changes
May 21, 2024
|
Thanks Alejandro, much appreciated. And indeed, it's not so much the speed but the security aspect that we care about! Thanks! |
acelaya
added a commit
to acelaya-forks/shlink
that referenced
this pull request
May 23, 2024
Replaces short-id by nano-id
|
I have just released Shlink 4.1.1 which includes this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
According to this: https://github.com/dylang/shortid?tab=readme-ov-file, shortid has been deprecated as it's deemed unsafe. Although the PHP version looks to be better, it relies on yet other libraries and is pretty big for what it does.
NanoId is a lot simpler and smaller, so I'd suggest to switch. This should do the trick.