Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AoT support #211

Merged
merged 2 commits into from
Oct 3, 2016
Merged

AoT support #211

merged 2 commits into from
Oct 3, 2016

Conversation

shlomiassaf
Copy link
Owner

@isaacplmann
This is the PR with you commit inside (squashed)

Please review.

Thanks!

@shlomiassaf shlomiassaf mentioned this pull request Oct 2, 2016
Closed
@isaacplmann
Copy link
Contributor

I'll check it out on Monday. Thanks for the hard work.

On Oct 1, 2016 8:05 PM, "Shlomi Assaf" [email protected] wrote:

@isaacplmann https://github.com/isaacplmann
This is the PR with you commit inside (squashed)

Please review.

Thanks!

You can view, comment on, or merge this pull request online at:

#211
Commit Summary

  • misc: refactor code base in preparation for AoT support
  • refactor(build): refactor to support AoT

File Changes

Patch Links:

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#211, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AA0lQIScK7lZIpL12rtrORquoU2WHKSSks5qvvVWgaJpZM4KL5Wv
.

refactor(build): refactor to support AoT
9db8f5e 
BREAKING CHANGE:
NPM Package now comes with ES6 Module version (ESM) and an ES5 UMD bundle (1 file), this should'nt have any effect. (CJS version removed)
ES6 version contains `d.ts` files as well as `metadata.json` files for AoT Compilation.

This breaking change mainly effect the development process of angular2-modal.
To support AoT a complete restructiing of the NPM package and build process was needed. Some devDependencies removed and some changed.
Development process is now managed by Webpack 2.
It is recommended to delete the node_modules directory and `npm install` again.

closes #206
closes #207
closes #204
@shlomiassaf shlomiassaf mentioned this pull request Oct 2, 2016
Open
@shlomiassaf shlomiassaf merged commit 9db8f5e into master Oct 3, 2016
@isaacplmann
Copy link
Contributor

Looks good to me. 2.0.0 compiles in the AoT compiler in my app. I'm looking forward to the day when the tooling around ng2 settles down a bit and we don't have to rewrite the build process every 2 months.

@isaacplmann
Copy link
Contributor

I spoke too soon, my app doesn't compile with angular2-modal 2.0.0. I'll file a proper issue in a bit.

@isaacplmann
Copy link
Contributor

isaacplmann commented Oct 4, 2016 •
edited
Loading

Having a tough morning. After clearing the cache, everything is fine. No issue from me.

@shlomiassaf shlomiassaf deleted the aot-support branch December 22, 2016 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shlomiassaf @isaacplmann