Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass config file to black, if present #63

Open
dcode opened this issue Aug 12, 2022 · 1 comment · May be fixed by #64
Open

Pass config file to black, if present #63

dcode opened this issue Aug 12, 2022 · 1 comment · May be fixed by #64

Comments

@dcode
Copy link

dcode commented Aug 12, 2022

This is similar to #9, but if additional black settings are configured in pyproject.toml beyond the include/exclude directives, it would be nice to have pytest-black honor those. I think this is as simple as adding --config pyproject.toml to the command argv in runtest(). This fixes my issues with line length discrepancy between config and test.

I can submit a PR to address it.
@dcode dcode linked a pull request Aug 12, 2022 that will close this issue
Open
@robertschonfeld
Copy link

Hey, I think your issue is not correct. This package does honor the pyproject.toml configuration as it's doesn't prevent the default behaviour of Black to look for this file.

There is the issue #65 which may cause confusion for new users as it did for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Passes pyproject.toml to black, if present dcode/pytest-black
2 participants
@dcode @robertschonfeld