fix(tests): Updates pytest fixture and Path uses - no functional change #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here we update API calls to use the latest reccomended:
* all 'testdir' fixtures now use the prefered 'pytester' fixture (the
same in all usecases for pytest-black).
* all 'Path.write' uses now use the more explicit `Path.write_text' api
instead.
* we replace `makefile("pyproject.toml", ...` with `makepyprojecttoml(`
which is clearly defined just for this usecase.
There should be no functional change with this patch, except that older
python versions are probably no longer supported.
|
This looks good to me. Let's just make sure the CI pipeline completes so that we know that it still works on the versions of Python that this project supports. |
rbebb
approved these changes
Jul 15, 2022
Is there any thing I need to do? |
|
@doublethefish It looks like the site they were using for testing (travis-ci.org) is no longer active. I created a ticket to get testing up and running again: #60. Someone with write access to the repo needs to do it though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we update API calls to use the latest reccomended:
same in all usecases for pytest-black).
instead.
makefile("pyproject.toml", ...withmakepyprojecttoml(which is clearly defined just for this usecase.
There should be no functional change with this patch, except that older
python versions are probably no longer supported.