Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update existing templates to Delay v2 #484

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jlyon
Copy link
Collaborator

@jlyon jlyon commented Jul 26, 2023

Description

For each of the templates below, complete these steps:

  • Install template (by uploading mesa.json, or a zip of the folder if it contains a custom script)
  • Confirm tokens look good in the builder
  • Test (if easy), confirm expected results

Templates updated:

  • gorgias/ticket/send_gift_card_when_order_delayed/mesa.json
  • shopify/draft_order/remove_after_thirty_days/mesa.json
  • shopify/order/lock_editing_with_tags/mesa.json
  • shopify/order/send_email_to_loyaltylion_customer_if_rewards_not_used/mesa.json
  • shopify/order/send_gift_card_for_orders_over_100/mesa.json
  • shopify/order/send_thanks_io_postcard/mesa.json
  • shopify/order/send_to_delighted_nps_survey/mesa.json
  • shopify/product/add_and_remove_tags_on_new_products/mesa.json
  • stamped_io/review/send_negative_review_to_customer_email/mesa.json
  • tracktor/fulfillment/automatically_set_custom_status/mesa.json
  • tracktor/fulfillment/delay_in_transit_email/mesa.json
  • tracktor/fulfillment/delay_in_transit_sms/mesa.json
  • tracktor/fulfillment/delay_in_transit_twilio_sms/mesa.json
  • tracktor/fulfillment/email_when_package_takes_too_long/mesa.json
  • tracktor/fulfillment/send_to_delighted_nps_survey/mesa.json
  • tracktor/fulfillment/send_to_stampedio_review_request/mesa.json
  • tracktor/order/refund_shipping_cost/mesa.json
  • shopify/order/send_to_salesforce_opportunity_and_opportunity_products/mesa.json (updated in Loop v2 PR)
  • shopify/product/send_to_salesforce_product_and_pricebook_entry/mesa.json (updated in Loop v2 PR)

QA Checklist

  • Does the template work

PR Review Checklist

mesa.json

  • key: Use the slug provided in the task of the MESA Templates list.
  • name: Use the name provided in the task of the MESA Templates list.
  • version: Keep as is.
  • description: Remove this since we rely on Prismic.
  • seconds: Remove this since we rely on Prismic.
  • enabled: Set to false
  • setup: Set to true to add the template setup. Otherwise, keep false if template setup is not applicable. For Google Sheets templates, set to custom as mentioned in the Authoring templates that support the setup wizard documentation.
  • Do the Input/Output names make sense? How about the keys?

Template code (Custom Code, Transform)

  • Is code readable and well-commented?

Deploy Checklist

  • Squash and merge PR

@anhdungpham
Copy link
Contributor

@jlyon

(1) A lot of these templates have a long Delay step, so I don't believe I would be able to do an actual test as they are intended. Mainly I just checked the variables for each template.

I did test the shopify/order/send_gift_card_for_orders_over_100/mesa.json template. That worked properly.

  • shopify/product/send_to_salesforce_product_and_pricebook_entry/mesa.json (updated in Loop v2 PR)

(2) This template is still using Loop v1. Is this suppose to be changed to v2? Or is this handled in the Loop v2 PR as you mentioned?

Screenshot 2023-07-27 at 9 37 24 AM

@jlyon
Copy link
Collaborator Author

jlyon commented Jul 28, 2023

@anhdungpham

(1) "Mainly I just checked the variables for each template." This sounds good.

(2) Good catch, I just pushed a commit to update this loop to v2

@anhdungpham
Copy link
Contributor

@jlyon Thanks for the updates.

  • shopify/product/send_to_salesforce_product_and_pricebook_entry/mesa.json (updated in Loop v2 PR)

The Loop step does not display fully. Could you please take another look?

Screenshot 2023-08-02 at 8 52 30 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants