Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template: Tag products as 'on sale' if the price is lower than the compare price #524

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

anhdungpham
Copy link
Contributor

@anhdungpham anhdungpham commented Dec 11, 2023

Description

Asana: Tag products as on sale when the price is cheaper than the compare price

QA Checklist

  • Go to MESA and import the template via shopify/product/tag_on_sale_if_price_lower_than_compare_price/mesa.json file
  • Go through the Template Setup. Do the question(s) make sense?
  • Turn on workflow
  • Turn on Logging and Logging debug mode
  • Save changes
  • Go to your Shopify admin
  • Create a new product with variants or view an existing product with variants
  • Adjust one of the variants so that the price of the variant is less than the compare at price
  • Save changes
  • Go back to MESA
  • Check that the workflow ran successfully
  • Check that the product was tagged with your desired tag
  • Does the template work

PR Review Checklist

mesa.json

  • key: Use the slug provided in the task of the MESA Templates list.
  • name: Use the name provided in the task of the MESA Templates list.
  • version: Keep as is.
  • description: Remove this since we rely on Prismic.
  • seconds: Remove this since we rely on Prismic.
  • enabled: Set to false
  • setup: Set to true to add the template setup. Otherwise, keep false if template setup is not applicable. For Google Sheets templates, set to custom as mentioned in the Authoring templates that support the setup wizard documentation.
  • Do the Input/Output names make sense? How about the keys?

Template code (Custom Code, Transform)

  • Is code readable and well-commented?

Deploy Checklist

  • Squash and merge PR

@amandahom
Copy link
Contributor

@anhdungpham Hey!

  • Maybe the question/description can be: What tag would you like to add to products that are on sale? // Enter the name of the tag. Multiple tags can be separated by commas.
  • It works but it causes a loop since its updating the product and triggering on updates. Maybe add a Filter to check for the tag?

@anhdungpham
Copy link
Contributor Author

@amandahom Thanks for the feedback! I wasn't sure of what the first question would be. I shall ask Jen for thoughts unless you have any. No need to take too long to think about it if you don't have any ideas.

Could you please pull in the new updates and double check?

@amandahom
Copy link
Contributor

@anhdungpham Looks good! I am not familiar with how we do questions that require copying the value and pasting into a different question. Wouldn't that apply here? Anyway, probably best to ask Jen.

@anhdungpham
Copy link
Contributor Author

Blocked by this task: Template Setup: Copy what was filled in for another question

This one is on paused for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants