-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
header ID generated are not compatible with ID generated on Github #320
Comments
@veggiemonk thanks! |
I did |
latest version should address this and more. We're replacing spaces with dashes and removing the following characters: Can you check if these characters are enough or if there are more that github replaces? |
I've grabbed the replaced chars from github's redcarpet. https://github.com/vmg/redcarpet/blob/v3.4.0/ext/redcarpet/html.c#L276 Added The improved version is available from commit d499feb onward |
@tivie great job, thanks a lot! |
Hi,
This is a great project!
For instance, on a README.md hosted on Github:
# Title Example
--><h1 id="title-example">Title Example</h1>
Same file but converted with Showdown:
# Title Example
--><h1 id="titleexample">Title Example</h1>
A dash
-
replace the space on github but showdow just erase it.Is there an option for that?
Otherwise we cannot be consistent with url when referring to a header.
Thanks a lot
The text was updated successfully, but these errors were encountered: