Revert "Revert "Merge branch 'main' of https://github.com/twilio/twil…

…io-cli""

This reverts commit 46eeca5.

.github/scripts/pack-debian-apt.js

@@ -86,19 +86,20 @@ PATH=$PATH:$PWD/bin eval $(PATH=$PATH:$PWD/bin node -p "require('./package').scr
     try {
       // fetch existing Packages file which needs to be modified for new version
       await qq.x(`aws s3 cp s3://${pjson.oclif.update.s3.bucket}/apt/Packages Packages`, {cwd: dist, reject: false});
-      const content = readFileSync("Packages");
-      fs.readFile('Packages', function (err, data) {
-        if(err) throw err;
-        // check if version already exists
-        if(data.includes(`Version: ${debVersion}`)){
-          console.log('the version ${debVersion}` is already available');
-          return
-        }
-      });
+      const content = fs.readFileSync(`${dist}/Packages`);
     }
     catch(error) {
       console.log(`Cannot retrieve Packages file due to error: ${error} `);
+      throw error;
     }
+    fs.readFile(`${dist}/Packages`, function (err, data) {
+    if(err) throw err;
+    // check if version already exists
+    if(data.includes(`Version: ${debVersion}`)){
+      console.log(`the version ${debVersion} is already available`);
+      throw new Error('verion already exists');
+      }
+    });
     for (const a of arch) {
       await build(a);
       await qq.x(`apt-ftparchive packages ${debArch(a)}/ >> Packages`, {cwd: dist});

.github/scripts/pack_macos.sh

@@ -30,7 +30,7 @@ notarize_and_staple() {
     notarization_status=$(jq -r .status $RUNNER_TEMP/notarization_log.json)
     notarization_id=$(jq -r .id $RUNNER_TEMP/notarization_log.json)
     echo "for notarization id ${notarization_id} the status is ${notarization_status}"
-    if [${notarization_status} = "Accepted"]
+    if [ "${notarization_status}" = "Accepted" ]
     then
       xcrun stapler staple "$FILE_PATH"
       spctl --assess -vv --type install "$FILE_PATH"

.github/workflows/audit-check-job.yml

@@ -0,0 +1,74 @@
+name: Audit check job
+on:
+  schedule:
+    - cron: '30 14 * * *'
+    - cron: '30 14 * * 3'
+jobs:
+  audit-prod:
+    if: github.event.schedule == '30 14 * * *'
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        node-version: [18.x, 16.x, 14.x]
+    steps:
+      - name: Checkout cli repo
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
+      - run: make install
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v2
+        with:
+          node-version: ${{ matrix.node-version }}
+          cache: 'npm'
+      - name: Run audit check
+        run: npm audit --production
+      - name: Notify Npm Audit Failed
+        if: ${{ failure() && github.ref == 'refs/heads/main' }}
+        uses: rtCamp/action-slack-notify@v2
+        env:
+          SLACK_WEBHOOK: ${{ secrets.ALERT_SLACK_WEB_HOOK }}
+          SLACK_COLOR: 'danger'
+          SLACK_USERNAME: CLI Github Actions
+          SLACK_MSG_AUTHOR: twilio-dx
+          SLACK_ICON_EMOJI: ':github:'
+          SLACK_TITLE: "Twilio Cli"
+          SLACK_MESSAGE: 'Cli daily production audit test failed'
+          MSG_MINIMAL: actions url
+          SLACK_FOOTER: Posted automatically using GitHub Actions
+
+  audit-dev:
+    if: github.event.schedule == '30 14 * * 3'
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        node-version: [ 18.x, 16.x, 14.x ]
+    steps:
+      - name: Checkout cli repo
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
+      - run: make install
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v2
+        with:
+          node-version: ${{ matrix.node-version }}
+          cache: 'npm'
+      - name: Run audit check
+        run: npm audit --dev
+
+      - name: Notify Npm Audit Failed
+        if: ${{ failure() && github.ref == 'refs/heads/main' }}
+        uses: rtCamp/action-slack-notify@v2
+        env:
+          SLACK_WEBHOOK: ${{ secrets.ALERT_SLACK_WEB_HOOK }}
+          SLACK_COLOR: 'warning'
+          SLACK_USERNAME: CLI Github Actions
+          SLACK_MSG_AUTHOR: twilio-dx
+          SLACK_ICON_EMOJI: ':github:'
+          SLACK_TITLE: "Twilio Cli"
+          SLACK_MESSAGE: 'Cli weekly dev audit test failed'
+          MSG_MINIMAL: actions url
+          SLACK_FOOTER: Posted automatically using GitHub Actions

CHANGES.md

@@ -1,4 +1,55 @@
-## [3.6.0](https://github.com/twilio/twilio-cli/compare/3.5.0...3.6.0) (2022-07-14)
+## [4.1.0](https://github.com/twilio/twilio-cli/compare/4.0.1...4.1.0) (2022-08-25)
+
+
+### Library - Features
+
+* added audit cronjob ([#437](https://github.com/twilio/twilio-cli/issues/437)) ([0ffd3e1](https://github.com/twilio/twilio-cli/commit/0ffd3e1895cbc6fb591cff7ad27f8a0c08602070))
+
+
+### Library - Chores
+
+* bump file-type from 14.7.1 to 16.5.4 ([#426](https://github.com/twilio/twilio-cli/issues/426)) ([3577303](https://github.com/twilio/twilio-cli/commit/35773036174a3c8012789dccba11629ce16e4b2e))
+* update macos failing script ([7c5b231](https://github.com/twilio/twilio-cli/commit/7c5b231a3eea0e0ac70f56d8737c94eaf66fb846))
+* update macos failing script ([#452](https://github.com/twilio/twilio-cli/issues/452)) ([0e09e6e](https://github.com/twilio/twilio-cli/commit/0e09e6ed35de6b48d4253aa582ca3bdb487485bb))
+* update macos failing script ([#453](https://github.com/twilio/twilio-cli/issues/453)) ([9a95b91](https://github.com/twilio/twilio-cli/commit/9a95b91a11a95c6c34ee52171e324c70f9c987d8))
+
+---------------------------
+**Library - Test**
+- [PR #73](https://github.com/twilio/twilio-oai/pull/73): add test-docker rule. Thanks to [@beebzz](https://github.com/beebzz)!
+
+**Api**
+- Remove  from scheduling params and remove optimize parameters. **(breaking change)**
+
+**Routes**
+- Remove Duplicate Create Method - Update Method will work even if Inbound Processing Region is currently empty/404. **(breaking change)**
+
+**Twiml**
+- Add new Polly Neural voices
+- Add new languages to SSML .### [4.0.1](https://github.com/twilio/twilio-cli/compare/4.0.0...4.0.1) (2022-08-11)
+
+
+### Library - Chores
+
+* updated commit msg ([6390c78](https://github.com/twilio/twilio-cli/commit/6390c788cb730aa9ea3dcbf261115d81fec779dd))
+
+## [4.0.0](https://github.com/twilio/twilio-cli/compare/3.6.0...4.0.0) (2022-08-11)
+
+
+### ⚠ BREAKING CHANGES
+
+* node engines support 14.x+
+
+### Library - Chores
+
+* update dependencies ([#430](https://github.com/twilio/twilio-cli/issues/430)) ([bc4703d](https://github.com/twilio/twilio-cli/commit/bc4703d6eb0210183ce92491188325f82e91d212))
+
+
+### Library - Fixes
+
+* add node engine support from 14.x+ ([ef520fd](https://github.com/twilio/twilio-cli/commit/ef520fd5ca9eaba14ef134a10173fa6050a61929))
+* cleanup keytar and port command ([#436](https://github.com/twilio/twilio-cli/issues/436)) ([d00f7ee](https://github.com/twilio/twilio-cli/commit/d00f7ee019b14ae38abda86eb4c910ac3e4b3ff7))
+
+---------------------------   **Library - Feature**   - [PR #72](https://github.com/twilio/twilio-oai/pull/72): Addition of spec files for preview domain. Thanks to [@AsabuHere](https://github.com/AsabuHere)!      **Routes**   - Inbound Proccessing Region API - Public GA      **Supersim**   - Allow updating  on a Fleet## [3.6.0](https://github.com/twilio/twilio-cli/compare/3.5.0...3.6.0) (2022-07-14)
 
 ---------------------------
 **Library - Test**

Makefile

@@ -26,7 +26,7 @@ docker-push:
 	docker push twilio/twilio-cli:apidefs-${API_DEFINITIONS_SHA}
 	docker push twilio/twilio-cli:latest
 
-# make owner=custom-user generate-fork-pipeline-changes
+# make owner=username generate-fork-pipeline-changes
 generate-fork-pipeline-changes:
 	git co main
 	node .github/scripts/create-fork-pipeline-changes.js $(PWD) $(owner)