Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve scrollbar accessibility #4115

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hichemfantar
Copy link
Contributor

@hichemfantar hichemfantar commented Jan 30, 2025

Why:

improves scrollbar accessibility, shows the user where the content starts and ends, better contrast, brings back inactive, hover, and active (on windows and linux) states

this also removes outdated styles, scrollbar styles are now properly supported

scrollbars can also be customized by the user on the OS or browser level so it's best to stick to native styles as much possible to avoid overriding user settings

https://developer.mozilla.org/en-US/docs/Web/CSS/scrollbar-width#browser_compatibility

tested across all browsers and OSes

What's being changed (if available, include any code snippets, screenshots, or gifs):

before
image

after
image

before (hover state)

Screen.Recording.2025-01-30.at.2.52.38.AM.mp4

after (hover state)

Screen.Recording.2025-01-30.at.2.52.56.AM.mp4

Check off the following:

  • I have reviewed my changes in staging, available via the View
    deployment
    link in this PR's timeline (this link will be available after
    opening the PR).

Copy link

changeset-bot bot commented Jan 30, 2025

⚠️ No Changeset found

Latest commit: 50e3181

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextra-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 1:52am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
nextra ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2025 1:52am

Copy link

vercel bot commented Jan 30, 2025

@hichemfantar is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@dimaMachina dimaMachina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you send some windows screenshot before/after 🙏?

@hichemfantar
Copy link
Contributor Author

image

image

@hichemfantar
Copy link
Contributor Author

this also fixes a bug on firefox windows where the scrollbar becomes invisible when clicked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants