Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting stops working when inline @php directive present in tag #156

Closed
holaontiveros opened this issue Oct 12, 2022 · 8 comments
Closed
Assignees

Comments

@holaontiveros
Copy link

holaontiveros commented Oct 12, 2022

Hi, thanks a lot for the plugin just wanted to report a possible bug

When having something like:

<article @php(post_class('lg:pt-10'))>
            <header class=" px-0 lg:px-4 container"></header>
</article>

the code get's formated to:

<article
    @php(post_class('lg:pt-10'))>
            <header class=" px-0 lg:px-4 container"></header>
</article>

if the @php inline directive is remove or changed to @php @endphp the formatting works as expected.

This includes all types of formatting, including the tailwind sorting that made me realize my file was being formatted as expected

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Dec 12, 2022
@shufo shufo removed the Stale label Dec 12, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added Stale and removed Stale labels Feb 11, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added Stale and removed Stale labels Apr 14, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Jun 20, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 30, 2023
@shufo shufo removed the Stale label Jun 30, 2023
@shufo shufo reopened this Jun 30, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Aug 30, 2023
@shufo shufo removed the Stale label Aug 30, 2023
@calebdw
Copy link

calebdw commented Oct 10, 2023

Note that Laravel has deprecated the inline @php() directive:

laravel/framework#48420 (comment)

Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Dec 10, 2023
@shufo shufo removed the Stale label Dec 10, 2023
Copy link
Contributor

github-actions bot commented Feb 9, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Feb 9, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants