[10.x] Fix blade failing to compile when mixing inline/block @php directives

[calebdw]

Closes #48407

Updated the php regex from .*? to (?:.(?!(?<!@)@php))*?---long story short this is just a negative lookahead that matches everything that is not followed by @php while also allowing @@pphp.

Partial credit goes to @rikvdh

[calebdw]

Not sure why the test is failing, everything passed when I first created this PR and the only thing I changed was adding some more cases to the test...

[taylorotwell]

Looks like they are failing on PHP 8.3. They are not failing on PHP 8.3 for other framework PRs that are open at the moment.

[taylorotwell]

Could you mark as ready for review again once tests are passing?

[calebdw]

@taylorotwell, tests are passing after rebase

[taylorotwell]

The additional tests suggested by @crynobone do not pass:

    public function testCompilationOfMixedPhpStatements()
    {
        $string = '@php($set = true) @php ($hello = \'hi\') @php echo "Hello world" @endphp';
        $expected = '<?php ($set = true); ?> <?php ($hello = \'hi\'); ?> <?php echo "Hello world" ?>';

        $this->assertEquals($expected, $this->compiler->compileString($string));
    }

    public function testCompilationOfMixedUsageStatements()
    {
        $string = '@php (
            $classes = [
                \'admin-font-mono\', // Font weight
            ])
        @endphp';
        $expected = '<?php (
            $classes = [
                \'admin-font-mono\', // Font weight
            ])
        ?>';

        $this->assertEquals($expected, $this->compiler->compileString($string));
    }

    public function testMultilinePhpStatementsWithParenthesesCanBeCompiled()
    {
        $string = "@php ("
                ."\n    \$classes = ["
                ."\n        'admin-font-mono'"
                ."\n    ])"
                ."\n@endphp"
                ."\n"
                ."\n<span class=\"{{ implode(' ', \$classes) }}\">Laravel</span>";

        $expected = "<?php (\n"
                ."    \$classes = [\n"
                ."        'admin-font-mono'\n"
                ."    ])\n"
                ."?>\n"
                ."\n"
                ."<span class=\"<?php echo  implode(' ', \$classes); ?>\">Laravel</span>";

        $this->assertEquals($expected, $this->compiler->compileString($string));
    }

    public function testMixedOfPhpStatementsCanBeCompiled()
    {
        $string = "@php(\$total = 0)"
                ."\n{{-- ... --}}"
                ."\n<div>{{ \$total }}</div>"
                ."\n@php"
                ."\n    // ..."
                ."\n@endphp";

        $expected = "<?php (\$total = 0); ?>\n"
                ."\n"
                ."<div><?php echo e(\$total); ?></div>\n"
                ."<?php\n"
                ."    // ...\n"
                ."?>";

        $this->assertEquals($expected, $this->compiler->compileString($string));
    }

[taylorotwell]

@calebdw please mark as ready for review again when tests are addressed

[calebdw]

@taylorotwell,

There was a mistake in the third test (should be echo e(implode(...))), I've added the additional tests and corrected the mistake.

[taylorotwell]

Thanks - will give this a shot.

[jorisleermakers]

I have faced an issue today, after updating Laravel from 10.24.0 to 10.25.0 by this change.
If you have a single-line PHP Statement that includes a ? or : the blade is failing to parse after this change.

Works:
@php ($var = ('a' == 'b'))

Does not work anymore:
@php ($var = ('a' == 'b' ? 'x' : 'y'))

It works again if you end the line with @endphp But that should not be mandatory.
@php ($var = ('a' == 'b' ? 'x' : 'y')) @endphp works

[QuentinGab]

Hi,
I can confirm that inlined @php is broken when using ternary.

[dwightwatson]

Chiming in here as I've had trouble upgrading to the latest version and I suspect this may be the culprit. Curiously my tests pass locally but they fail in CI (GitHub Actions) and I can't narrow down why.

TypeError: Livewire\Volt\VoltServiceProvider::Livewire\Volt\{closure}(): Argument #1 ($value) must be of type string, null given, called in /home/runner/work/roomies/roomies/vendor/laravel/framework/src/Illuminate/View/Compilers/BladeCompiler.php on line 262 and defined in /home/runner/work/roomies/roomies/vendor/livewire/volt/src/VoltServiceProvider.php:42

I ended up removing Volt and then my tests passed in CI again.

I deployed to production and then some customers complained about receiving blank pages and I was able to replicate. Rolled back to 10.24.0 and the problem has gone away.

[mikescola]

This has caused massive issues, and unfortunately I didn't check my app's checkout page when I did the upgrade. Prime example of how tests give you a false sense of security. Can confirm this breaks @php($needsToIncrement++) as well, not just ternary.

[jorisleermakers]

@taylorotwell Maybe revert this commit in a next minor release? As it causes more issues then solving.

[calebdw]

@jorisleermakers, @QuentinGab, @dwightwatson @mikescola, @driesvints.

Additional information is needed along with a minimum reproducible example---I added tests for the specific use cases above and they pass regardless of the old or new regex.

I'm specifically interested in if there are any @php tags before or after the ones that have issues.

[driesvints]

We're reverting this and removing @php() from the docs. We won't recommend using it any further only @php @endphp.

[QuentinGab]

@jorisleermakers, @QuentinGab, @dwightwatson @mikescola, @driesvints.

Additional information is needed along with a minimum reproducible example---I added tests for the specific use cases above and they pass regardless of the old or new regex.

I'm specifically interested in if there are any @php tags before or after the ones that have issues.

I understand that, but I did not succeeded to reproduce the problem with only a simple blade view and inline php.
I assume that the error is not simply caused by the usage of ternary or nullish operator but in combination with something else.