Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy EonKeyPublish contract in AddKeyerSet.gnosh.s.sol #1

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

fredo
Copy link
Contributor

@fredo fredo commented Sep 16, 2024

No description provided.

Copy link
Contributor

@konradkonrad konradkonrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - there is also the alternative version at https://github.com/shutter-network/contracts/blob/e7332733f1cf7a4fe440bcae897a9b2216b8f3ac/script/AddKeyperSet.s.sol

Judging from the "merge contract issue" shutter-network/rolling-shutter#517 that one may have been the version previously used.

The only difference I could immediately spot was a check for activation_delta > 0

@konradkonrad
Copy link
Contributor

looks good - there is also the alternative version at https://github.com/shutter-network/contracts/blob/e7332733f1cf7a4fe440bcae897a9b2216b8f3ac/script/AddKeyperSet.s.sol

Judging from the "merge contract issue" shutter-network/rolling-shutter#517 that one may have been the version previously used.

The only difference I could immediately spot was a check for activation_delta > 0

Feel free to delete either version, if your deployment is successful with the other one.

@fredo fredo force-pushed the deploy-publish-contract branch from 490cdb8 to 996467f Compare September 16, 2024 10:16
@fredo
Copy link
Contributor Author

fredo commented Sep 16, 2024

taking the other one, has also some benefits like higher solidity version and custom errors

@fredo fredo force-pushed the deploy-publish-contract branch from 996467f to ac2c31c Compare September 16, 2024 10:19
@fredo fredo merged commit 9337160 into main Sep 16, 2024
2 checks passed
@fredo fredo deleted the deploy-publish-contract branch September 16, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants