Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Replace .chain() with .sources() and fix test_macros #338

Closed
wants to merge 2 commits into from

Conversation

iamwacko
Copy link
Collaborator

@iamwacko iamwacko commented Sep 3, 2022

Fixes #337. We shouldn't need to pin nightly once this works.

@iamwacko
Copy link
Collaborator Author

iamwacko commented Sep 4, 2022

The tests were not being run with the dependencies in the Cargo.lock, so the builds kept failing. This should fix the problem where all of the other PR's keep failing tests.

@iamwacko iamwacko changed the title Fix: Replace .chain() with .sources() Fix: Replace .chain() with .sources() and lock dependencies during tests Sep 4, 2022
@iamwacko iamwacko force-pushed the sources-nightly branch 2 times, most recently from 4d862dd to 3c677fe Compare September 5, 2022 17:34
@iamwacko iamwacko changed the title Fix: Replace .chain() with .sources() and lock dependencies during tests Fix: Replace .chain() with .sources() and fix test_macros Sep 5, 2022
@iamwacko iamwacko closed this Oct 1, 2022
@iamwacko iamwacko mentioned this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed Compilation
1 participant